Repository navigation
fix(ci): warn when a pinned conda release has lost a wheel (#2028) - #2035
Merged
Merged
Conversation
- refresh() now warns when the newest release with a wheel for every conda Python is older than the pin, naming the tags the pinned release lacks and the newest release that still qualifies; the new lost() helper words it. The pin stays and the step still passes. - A pin that is still the newest qualifying release stays silent, as does one above the installed release. - cron-conda.yml: the refresh step's comment covers the new warning. - Tests: unit and end-to-end cases for the warning, and the silent case.
JarryShaw
added
bug
Owner
Author
|
GOOD TO GO at |
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ordering check on |
JarryShaw
removed
the
review: good-to-go
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
Closes #2028. In
refresh(), the statenewest is not None and target is Nonecovered two cases: the pin is still the newest qualifying release, which is right to stay silent, and the pinned release has lost a wheel (newest < pin), which was wrongly silent.elif Version(newest) < current < ceiling, emits a::warning. The new helperlost()names the tags the pinned release lacks, or says PyPI no longer lists that release. The step still exits 0.Refresh the platform pinsincron-conda.ymlnames the case.Example:
cryptography 48.0.1 on osx-64 stays as it is, and may no longer hold: 48.0.1 has no wheel for cp311 on osx-64, and the newest release up to 52.0.0 with wheels for all of cp311, … there is 47.0.0.The new tests fail without the fix (
5 failed, 48 passed) and pass with it (51 passed). Two tests check that a pin that is still the newest, and a pin above the installed release, stay silent. The 25 files that readcron-condaor the workflows give714 passed.