Repository navigation
ci(conda): drop the unreachable Windows conda steps (#1967) - #2055
Merged
Merged
Conversation
`windows-latest` has been commented out of the conda matrices since 2023,
yet `conda` in create-release.yml and `conda-dist` in cron-conda.yml still
carried `Install and Setup (Windows)`, `Setup Conda Distribution (Windows)`,
the `matrix.os != 'windows-latest'` guards on their twins, and a
`windows-latest` arm in each `case "${{ matrix.os }}"`. Remove them, and
replace the commented matrix line with a note that adding the leg back means
writing its steps.
test_conda_no_windows_steps_1967 pins that no step's `if:` or `case` arm in
either job names a runner its matrix lacks, and that no step is Windows-only
while no leg is Windows. #1854's install-step count drops its Windows twin,
and util/conda_vendor.py's note on `bld.bat` no longer says "commented out".
JarryShaw
added
ci
Owner
Author
|
GOOD TO GO at
|
JarryShaw
added
review: good-to-go
Owner
Author
|
Ordering check on |
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
A smaller item from #1967.
windows-latesthas been commented out of both conda matrices since 2023, yet its steps stayed.create-release.yml'scondaandcron-conda.yml'sconda-dist:windows-latest→win-64casearms in Check whether this leg is already on Anaconda and Build conda packages.if: matrix.os != 'windows-latest'guards on the remaining install and setup steps.util/conda_vendor.py'sPLATFORMScomment now matches the matrices.conda/pypcapkit/bld.batis left as is.tests/project/test_conda_no_windows_steps_1967.pypins three rules. Noif:orcasearm names a matrix label the matrix lacks. No step is Windows-only while no leg is Windows. Self-checks prove both rules report.main's workflows (4 failed) and passes here.test_conda_legs_install_no_pcapkit_1854now expects one Install and Setup step.