Repository navigation
refactor(util): move update_python_versions onto the Actions helper (#2047) - #2069
Merged
Merged
Conversation
…2047) - util/update_python_versions.py: its annotations, its three step outputs and body's step summary go through util/_actions.py; its own escape() goes, the helper's escaping being the same. $GITHUB_OUTPUT unset or empty still fails as before, naming it, and output is unchanged. - tests/project/test_python_versions_update_1660.py: TestTheWorkflowCommands pins every annotation, output and summary line byte for byte, with text each escape changes; it passes on main and on this change. - tests/project/test_actions_helper_2047.py lists the script.
Owner
Author
|
GOOD TO GO at
|
Contributor
|
Coverage: 91.52% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
Part of #2047:
util/update_python_versions.pynow writes all its Actions output throughutil/_actions.py. Like #2063, the output is byte-identical.escape()._actions.annotate, outputs through_actions.set_output, and the step summary through_actions.summary.KeyErroron an unknown note kind and theRuntimeErrorwhen$GITHUB_OUTPUTis unset or empty.\w+trailer match, or an integer PR number, so none can contain%or a line break.TestTheWorkflowCommandsdrivesmain()with stubbedgit/gh. It compares whole stdout, return codes,$GITHUB_OUTPUTand the step summary byte for byte, using inputs with%,\r\n,:and,.mainand here.$GITHUB_OUTPUTcheck.test_actions_helper_2047lists the script.