Repository navigation
ci: read gh's 'no artifact matches' as no step summaries (#2074) - #2075
Merged
Merged
Conversation
`gh run download --pattern` fails with one of three messages when a run has nothing to download, per cli/cli pkg/cmd/run/download/download.go (runDownload): "no valid artifacts found to download" when the run has no unexpired artifact, and "no artifact matches any of the names or patterns provided" (gh >= 2.11.0; "... of the names provided" before) when none matches. Only the first was handled, so Discussion #2072 said the summaries "could not be read". Match each as a whole stderr line; any other failure still surfaces.
Owner
Author
|
GOOD TO GO at
|
4 of 5 tasks
Owner
Author
|
Ready to merge at |
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
Closes #2074.
util/check_suite_report.pytreated onlyno valid artifacts found to downloadas "no summaries". The first live report (Discussion #2072) instead showed gh'sno artifact matches any of the names or patterns providedas a failure to read the summaries.The messages: cli/cli's
runDownload(pkg/cmd/run/download/download.go) has three "nothing to download" messages, checked from v1.9.0 to trunk:no valid artifacts found to downloadno artifact matches any of the names or patterns provided(v2.11.0+)no artifact matches any of the names provided(up to v2.10.0)A new
NOTHINGset holds all three, and a failure counts as "no summaries" only when one of gh's output lines is exactly one of them. Every other failure still gives the "could not be read" line and a warning.Tests: a new stand-in
ghmode prints a given message.main, the twono artifact matchescases and the longer-line case fail.Results: the reporter, helper, KTLO-guard and discussion-report tests pass.