Repository navigation
ci: put two trivial util/ steps back inline (#1967) - #2092
Merged
Merged
Conversation
Owner
Author
|
GOOD TO GO at
|
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
Merged
4 of 5 tasks
Per the ruling on #1967, shell moves to util/ only when it is repeated or has real logic; these two are a few plain commands. - unit-tests.yml: engine-tests' and pypcap-parity's seed steps run their former three-line shell again, verbatim; util/apt_packages.py loses its seed subcommand (--archives stays, for collect). - create-release.yml: vendor_update's "Read whether its vendor-update job ran" holds its former shell again, verbatim, with no checkout, so the job is back to actions: read alone; util/release_vendor_update.py goes. - tests: the seed and vendor_update tests run the steps' own run: under bash on stand-ins and pin each body; the helper, checkout and #2030 pins drop the script. - workflows.rst: the scripts table and its intro say which shell stays inline.
Owner
Author
|
Rebased onto
|
JarryShaw
force-pushed
the
ci/1967-inline-trivial-steps
branch
from
October 23, 2026 17:27
9cfd040 to
1a42266
Compare
Owner
Author
|
GOOD TO GO at
Once its CI is green, I'll post the ready note. |
Owner
Author
|
Ready to merge at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
This applies #1967's inline rule to two migrations that are already merged. The rule moves shell into
util/only when it is duplicated or has real logic. The audit and the approval are on #1967.engine-testsandpypcap-parity): the 3-lineset -eu/sudo cp/echobody is back inline, matching657be8dc8^exactly.apt_packages.pydropsseed;plan,installandcollectstay.vendor_update: thegh api+casebody is back. The whole job, comment included, matches61bb4ba66^.util/release_vendor_update.pyis deleted. The job no longer checks oututil/, so it is back toactions: readalone.run:body under bash with stand-ins, over the same cases, and pin the job's permissions. 22 test files pass, and actionlint 1.7.12 is clean.workflows.rstscripts intro now states the rule, and the table rows are updated.Overlap: #2089 also edits
create-release.yml, the scripts table and theSCRIPTStuple intest_actions_helper_2047.py, so whichever merges second gets a small rebase.