Repository navigation
ci(release): move Reset Build Number into util/release_reset_build.py (#1967) - #2093
Merged
Merged
Conversation
…#1967) Per the 2026-10-23 ruling on #1967, judged step by step: of the github and tag jobs' remaining shell, only Reset Build Number has real logic (44 lines, a three-attempt push loop, five early exits, the #1634 history). Select release body, Explain a refused release tag and Create Tag stay inline, as does cron-conda.yml's release check. - util/release_reset_build.py: the former shell's decisions, git calls, lines and annotations, and its exit statuses under set -euo pipefail. - create-release.yml: the step runs the script, keeping its name and env. - tests: the former shell runs verbatim beside the script on scratch repositories, covering every way it ends; the step, its whole checkout, its git calls and 3.7 syntax are pinned. The helper test lists it. - workflows.rst: its row in the Workflow Scripts table.
JarryShaw
force-pushed
the
ci/1967-release-scripts-5
branch
from
October 23, 2026 18:36
3840ba8 to
eabadbd
Compare
Owner
Author
|
GOOD TO GO at
|
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
With this merged, every create-release step has been judged under the #1967 inline rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
This is the last create-release batch for #1967. Each step of the
githubandtagjobs, and cron-conda's Check the GitHub release exists, was judged against the inline rule.release_tags.pyreads the tag differently.util/release_reset_build.py: stdlib only and 3.7-parseable, since thetagjob has no setup-python. The step keeps its name, env and position.test_release_reset_build_1967runs the old shell verbatim beside the script, on scratch repos. It covers 24 cases across every exit, comparing status, output, origin refs, HEAD andconda/build. Five planted divergences were caught.