Repository navigation
docs: regenerate the engine benchmark with Python 3.15 measured - #2109
Merged
Merged
Conversation
Owner
Author
|
NEEDS CHANGES at
|
- python-images.txt: pin the released python:3.15-slim-bookworm (3.15.1) in place of the 3.15 rc, and make it a default-tier row. - requirements-common.txt: pin typing-extensions for 3.10; since pcapkit's compat imports it unconditionally there, the 3.10 pypcap virtualenv failed to import pcapkit and the 3.10 image no longer built. - report.py: underline the snippet headings with `-`, the level they take in docs/source/index.rst, so the snippets paste verbatim. - index.rst: replace the hand-measured macOS Test Environment/Test Results with a full examples/benchmark/run.sh run (3.10-3.15, cfabfb2), and drop the "3.15 inferred" and "tshark absent" footnotes from the support table now that 3.15 and pyshark are measured. - 3rdparty.rst: pyshark on 3.13 is checked, not "expected to work". - tests: exempt the generated snippets' engine/pcap literals from the rst_epilog link checks (#1936, #1948). Benchmark self-tests and the docs-pin tests pass.
JarryShaw
force-pushed
the
docs/engine-benchmark-315
branch
from
October 23, 2026 20:30
e94d74f to
970796e
Compare
Owner
Author
|
GOOD TO GO at
|
4 of 5 tasks
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
If #2112 merges first, the 3.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation only changesDescription of your pull request and other information
The engine tables in
docs/source/index.rstwere out of date now that 3.15 is released.40010064464engine jobs.3rdparty.rst's "pyshark on 3.13 is unchecked" now says it works.examples/benchmark/run.sh, 3.10–3.15, exit 0), pasted unedited. The numbers come from an x86_64 Linux host, so they are not comparable with the old figures.python:3.15-slim-bookwormimage (3.15.1) is pinned by digest as a default row.typing-extensionsis now installed for Python < 3.11, since the 3.10 image failed withModuleNotFoundError.report.pyunderlines headings atindex.rst's level.test_docs_epilog_links_1936_unitandtest_docs_pcap_module_link_1948_unitget narrow exemptions for the generated snippets. Each failed 1 case before the exemption, and both pass now.Noticed, not fixed:
pcap_cttakes 0.27 ms per packet on 3.15 against about 0.117 on 3.12–3.14, consistently across three passes. Filed separately.