Repository navigation
ci: run the corekit plain-unittest ordering leg (#2115) - #2116
Merged
Merged
Conversation
tests/corekit was left out of unittest-ordering as permanently red. The identity subtests that reason cited were fixed under #1332, and the rest of the leg's failures under the previous commit, so it now passes. - unit-tests.yml: add `corekit` to the matrix; the comment keeps tests/integration as the one deliberate omission, with its reason - test_unittest_ordering_shards: derive the expected legs from the tests/ subdirectories minus a documented NOT_LEGS set, and pin that integration has no unit-tier module, so a new subdirectory left out fails - test-coverage.rst: drop corekit from the "not legs" sentence The pin test fails against the old matrix (2 failures naming corekit) and passes with it. run_unittest_leg.py project: 2183 tests, 0 failures, 0 errors.
Owner
Author
|
GOOD TO GO at
|
Owner
Author
|
Ready to merge at
This closes #2115. |
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
Closes #2115. CI's
unittest-orderingmatrix had nocorekitleg, andutil/run_unittest_leg.py corekitfailed onmainwith 34 failures and 31 errors.main, test-only66a70edf4): bisection pinned the polluters totest_bitfield_unnamed_bits_1487_unitandtest_decorators_path_1735_unit, which callreimport_once_per_class. Leaving the freshpcapkitimport in place is intended in this leg (test: three modules pass alone but fail together, and pytest reports it green #981): it is how the leg catches modules that hold a stale import. The enum tests did hold one: they boundEnumLookup/EnumKeyError/EnumValueErrorat module load, so the fix imports those names per test. With it, the corekit leg runs 903 tests with 0 failures.corekitto the matrix.integrationstays out on purpose, as the workflow comment andrun_unittest_leg.pyrecord:is_unit_tier()rejects every file in it, so the leg would run nothing of its own, and theintegrationjob already runs it under pytest. The stale comment and the "not legs" sentence inconventions/test-coverage.rstare updated.test_unittest_ordering_shardsnow derives the expected legs from everytests/subdirectory with atest_*.py, minusNOT_LEGS = {'integration'}. Against the old workflow it fails 2 checks, both namingcorekit; it passes with the change.