Repository navigation
fix(conda): read conda-forge's CFEP-27 Windows layout in the smoke check (#2126) - #2127
Merged
Merged
Conversation
…eck (#2126) - util/conda_vendor.py: built_for recognises lib/python/site-packages, the layout conda-forge's CPython 3.15 uses on Windows (CFEP-27), beside Lib/site-packages, and reads the version from the pyXY build string for either. It returned the bare `python` before, failing the win-64 3.15 smoke. - tests/project/test_conda_windows_leg_2060.py: TestTheWindowsLayout covers the CFEP-27 path for built_for and end to end through smoke(). tests/project/test_conda_windows_leg_2060.py: 22 passed; the 2 new tests fail without the fix.
Owner
Author
|
GOOD TO GO at
|
This was referenced Oct 24, 2026
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
Closes #2126.
lib/python/site-packages. conda-build 26.9.1 setsSP_DIRfrom the python package'spython_site_packages_path.built_foronly knewLib/site-packages, so it returnedpythonand failed the win-64 3.15 smoke in run 40034513322.built_forrecognises both Windows layouts (WINDOWS_SITES) and reads the version from thepyXYbuild string for either.test: imports: pcapkitpassed in a fresh 3.15.1 env.TestTheWindowsLayoutcovers the CFEP-27 path inbuilt_forand end to end throughsmoke(). Both new tests fail without the fix. The module gives 22 passed.foreign()and the probe) has not run on real Windows 3.15. A build-only Conda Update run on this commit plus fix(release): read the environment without os.environb where Windows lacks it (#2120) #2122 and ci(conda): build the macos-26-intel legs again (#2123) #2124 will show it.