Repository navigation
fix(ci): give project-tests' unittest step a stall dump under its own cap (#2164) - #2184
Conversation
|
Review: GOOD TO GO at |
|
Ready to merge at
|
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
… cap (#2164) Problem: util/run_unittest_leg.py's default stall dump (1080s) is sized for unittest-ordering's 20-minute step cap. project-tests' step "Run tests/project and the root-level modules under plain unittest" is capped at 15 minutes, so a hang there was killed before the dump naming where it stopped could fire. Fix: that step passes --stall-dump 840, a minute under its cap; the script's docstring says a step with a shorter cap passes its own. Test: TestEveryStepDumpsBeforeItsCap reads every workflow step running the script and checks its effective dump (flag, env, else default) is below its timeout-minutes. It fails on origin/main with 1080 not less than 900.
|
Rebased onto
The patch changed only in a docstring line, but CI must re-run on the new head. A delta check follows. |
0f231fa to
badfc34
Compare
|
Review: GOOD TO GO at |
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription
Closes #2164.
util/run_unittest_leg.py's default stall dump, 1080s, is sized forunittest-ordering's 20-minute step. Theproject-testsstep "Run tests/project and the root-level modules under plain unittest" is capped at 15 minutes and passed nothing, so a hang there is killed before the dump fires.--stall-dump 840. The script's docstring says a step with a shorter cap passes its own; its code is unchanged.TestEveryStepDumpsBeforeItsCapintests/project/test_run_unittest_leg_stall_dump.py. For every workflow step that runs the script, it resolves the dump the script would use (flag, then env at step/job/workflow level, then default) and asserts it is above 0 and below the step's or job'stimeout-minutes. Onmainit fails with1080.0 not less than 900.0.unit-tests.yml. Thetests/projectfiles that name the workflow or script pass (807).