[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• docs — documentation only

---

Description

Part of #1103, ruling 1: test narratives stop describing a change and state the behaviour instead. This PR covers tests/foundation/ (except _roundtrip.py), tests/toolkit/, tests/integration/ and the root tests/*.py files.

• Rewrites:
  • "X now does Y" becomes "X does Y".
  • "used to / before this change, X did Z" becomes the defect the test guards against, e.g. "Guards against …" or "Without the fix, …", keeping the issue references.
  • History that adds nothing for a future reader is cut.
• Kept:
  • "no longer" and "now" where they describe the protocol, a runtime or a third-party tool, or the present moment.
  • Change-relative string literals and test names, since they are code, not prose.
• Scope: comments and docstrings only. Every changed file has the same AST as main once docstrings are stripped.
• Tests run: the changed files pass, slice by slice, along with the tier guard and the docstring contract.
• Overlap: docs(tests): fifth whole-repo pass over tests (#1103) #2159 conflicts in three files and docs(vendor): fix AppType template prose and six crawler Args mismatches (#2175) #2180 in one (tests/test_docstring_contract.py). Whichever lands second gets a rebase.

[JarryShaw]

Rebased onto main and the review fixes folded in: 948fadf03 → a83e5dcf3.

• Conflicts:
  • With docs(tests): fifth whole-repo pass over tests (#1103) #2159, in test_engine_base.py, test_tier_guard_xdist.py and test_pypcap_unusable_module_2132_unit.py. Its facts are kept: "below Python 3.11", the test: GraalPy experimental leg loses an xdist worker and fails tests on main #2082 citation, and the GraalPy-only lock polling.
  • With docs(vendor): fix AppType template prose and six crawler Args mismatches (#2175) #2180, in test_docstring_contract.py. Its KNOWN_DEFECTS text and the empty tuple are kept, and the cleanup applies only to the remaining prose.
  • test_pcap_backend.py drops out, since docs(tests): fifth whole-repo pass over tests (#1103) #2159 made the same edit.
• Review fixes:
  • The "pre-existing … exercised for the first time" and "Before Extractor._cleanup closes the caller-supplied stream and leaks the file it opened itself #610" lines are rewritten.
  • About 15 "Before the fix" hits become "Without the fix" or a statement of the defect.
  • The jumbogram header says "is dissected".
  • The xdist header names tests.test_tier_guard.
  • Missed phrases in test_extraction_no_eof.py, test_scapy_engine.py and the non-seekable-stream test are covered too.
• Checks: with docstrings stripped, all 53 files keep main's AST. The changed files pass in groups, along with the tier guard and the docstring contract.

A delta review of this head is running.

[JarryShaw]

Review: GOOD TO GO at 0ccaa39c6 (Sonnet delta, two findings dismissed). All five first-round findings are fixed, the conflict resolutions keep #2159's and #2180's facts, and the new subtest sentence matches pytest 9.1.1. The two remaining hits in test_extraction_no_eof.py stay as they are. "pre-existing matter" sits inside the child script's f-string, so it is code, and editing it changes the AST. "Measured on 6c3d1b0d9" is a commit-pinned measurement, which the cleanup keeps everywhere.

[JarryShaw]

Ready to merge at 0ccaa39c6. Part of #1103 (ruling 1).

• Review: Sonnet GOOD TO GO.
• CI: Required checks passed SUCCESS, 0 failed. Still open: the non-gating Python graalpy-25.4 (experimental) leg.
• KTLO: 12 legs, no warnings.
• Ordering: foundation leg merged into main, 738 tests, 0 failures.
• Conflicts: none with the current main.

[github-actions]

Coverage: 91.55% (unit tier, Python 3.15, 0ccaa39c6, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	880	2618	866	92.12%
pcapkit/corekit	2589	75	816	37	96.48%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	2971	23	1036	25	98.80%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17418	219	4574	185	98.14%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.