Repository navigation
test(util): raise the util scripts' syntax floor to 3.8 (#1103) - #2197
Merged
Merged
Conversation
Problem: the util scripts' syntax checks parsed with feature_version=(3, 7) and the util docstrings promised 3.7 syntax, though requires-python is >=3.8 and no leg has run 3.7 since #2051. Fix: the six checks parse at FLOOR from test_requires_python_floor_2051, which pins requires-python's floor; the docstrings and workflows.rst say 3.8. The self-documenting f-string check in test_actions_helper_2047 is removed: f'{x=}' is 3.8 syntax. Test: the changed tests pass; a walrus is rejected at (3, 7), accepted at FLOOR.
Owner
Author
|
Rebased onto
CI runs again on the new head. The cross-review in flight also covers this delta. |
JarryShaw
force-pushed
the
test/1103-util-syntax-floor-38
branch
from
October 25, 2026 14:21
05db861 to
9c6b5e3
Compare
Owner
Author
|
Review: GOOD TO GO at |
Owner
Author
|
Ready to merge at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
test— tests onlyDescription
Part of #1103, ruling 2: the
utilscripts' syntax floor rises from 3.7 to 3.8, matchingrequires-python.TestStandardLibraryOnlyintest_actions_helper_2047and the fivetest_release_*_1967syntax checks now parse atFLOOR.FLOORis imported fromtest_requires_python_floor_2051, the test that pinsrequires-python, so the version isn't a new literal.f'{x=}'is valid 3.8 syntax, and it existed only because 3.7 parsing accepted it.util/_actions.pyand sevenutil/release_*.pydocstrings say 3.8, as doesworkflows.rst's_actions.pysentence. With docstrings stripped, everyutilfile's AST matchesmain.feature_version=(3, 7)and accepted at(3, 8). The change loosens a check, so there is no failing-without-it test.tests/projectfiles that readworkflows.rst(452) all pass.util/_actions.pyparagraph. Whichever lands second takes docs(repo): fifth whole-repo pass over the repository files (#1103) #2158's wording with "3.8's syntax".