Repository navigation
docs(tests): state protocol, schema and misc tests' behaviour without change-relative narrative (#1103) - #2198
Merged
Merged
Conversation
… change-relative narrative (#1103) Rewrite comments and docstrings in tests/protocols/ (top level), tests/protocols/schema/ and tests/protocols/misc/ so they state the behaviour under test and the defect it guards against, rather than "now", "used to", "before the fix" or "on the unfixed tree". Comments and docstrings only; the AST with docstrings stripped is unchanged.
Owner
Author
|
Rebased onto
The earlier GOOD TO GO was for |
JarryShaw
force-pushed
the
docs/1103-cleanup-protocols
branch
from
October 25, 2026 14:32
1f3c2ac to
aad2f0c
Compare
Owner
Author
|
Review: GOOD TO GO at |
Owner
Author
|
Ready to merge at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, ruling 1: test narratives say what the behaviour is, not how a change altered it. This PR covers the files directly in
tests/protocols/plustests/protocols/schema/andtests/protocols/misc/. It excludes the round-trip and dispatch harness files, which #2165 owns.pcapng.py:Nline anchor and one count.main.