[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• docs — documentation only

---

Description

Part of #1103, ruling 1. Test narratives in tests/corekit/ (except _roundtrip.py), tests/utilities/, tests/dumpkit/, tests/interface/ and tests/cli/ now state the behaviour, not how a change produced it.

• Rewrites:
  • "used to …" becomes "Without the fix, … returns …".
  • "now" and "no longer" become the present tense.
  • Process and measurement histories are cut, but ruled-out alternatives keep their reasons.
• Stale claims corrected against the code:
  • A cross-reference to a test method that doesn't exist now names the real one.
  • byteorder.py:33 becomes the function name.
  • A base-class miss is no longer called "loud", since it went quiet in design(const): get(value, default) on an out-of-range value returns the default but logs a CRITICAL error and installs pcapkit's excepthook #1845.
  • The subtest note now matches what pytest 9 reports: a failing subTest is a counted SUBFAILED entry, while the parent counts as passed.
• Kept:
  • Runtime or third-party "now" and "no longer".
  • The moved-name tests' "old path", which is the subject of those tests.
  • Change-relative string literals and test names, which are code.
• Scope: comments and docstrings only. Once docstrings are stripped, every changed file has the same AST as main.
• Tests run: cli, interface, utilities and dumpkit pass (223), corekit passes (499), and so do the tier guard and docstring contract (140).
• Overlap: docs(corekit): say which generated registries bound their width (#2178) #2192 shares one file and merges cleanly.

[JarryShaw]

Review: NEEDS CHANGES at 2c80e6bb2 (Sonnet). Files this PR edits still carry change-relative proofs:

• "On stock <sha>" in test_fields_numbers_negative_length.py;
• "Measured on fix(reg,corekit): retype the registry NULL sentinel and raise ProtocolError from ModuleDescriptor.klass #835's head" in test_module.py;
• "before Address-typed SwitchField attributes bypass #491's bool guard: 3 mh.py makers still corrupt #508's fix" in test_fields_misc.py;
• "unfixed" in four utilities and corekit files.

There is also one garbled sentence. The rewrites themselves hold against the code, cross-references resolve, the subtest sentence is accurate and the tests pass. The worker is fixing the rest.

[JarryShaw]

Review fixes pushed: 2c80e6bb2 → d0e35e388, rebased onto main.

• Proofs: the "On stock <sha>", "Measured on fix(reg,corekit): retype the registry NULL sentinel and raise ProtocolError from ModuleDescriptor.klass #835's head" and "before Address-typed SwitchField attributes bypass #491's bool guard: 3 mh.py makers still corrupt #508's fix" proofs now state the defect.
• "unfixed": every occurrence now reads "without the fix", in 8 files.
• Wording: the garbled fix(corekit,utilities): raise pcapkit exceptions from EnumLookup.get, following stdlib Enum's shape #923 sentence is fixed, and lines that had grown over-long are rewrapped.
• Past tense: two past-tense narratives the grep missed are now in present tense.

The AST check is clean on all 57 files, and the slice tests pass. A delta review is running.

[JarryShaw]

Review: GOOD TO GO at d0e35e388 (Sonnet delta). Every earlier item is fixed and checked against the code, and only the intended hunks and pure reflows moved. The change-relative grep finds nothing in the 57 files. AST is clean, and corekit, utilities, dumpkit, interface, cli, the docstring contract and the tier guard all pass (1107).

[JarryShaw]

Ready to merge at d0e35e388. Part of #1103 (ruling 1).

• Review: Sonnet GOOD TO GO, after one NEEDS CHANGES round.
• CI: all checks complete, Required checks passed SUCCESS, 0 failed.
• KTLO: 12 legs, no warnings.
• Ordering: the corekit leg was merged into main and run: 924 tests, 0 failures.
• Conflicts: none against the current main.

[github-actions]

Coverage: 91.55% (unit tier, Python 3.15, d0e35e388, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	881	2618	867	92.11%
pcapkit/corekit	2589	74	816	37	96.51%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	2971	23	1036	25	98.80%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17433	219	4584	185	98.15%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.