Repository navigation
docs(protocols): sixth whole-repo pass over internet (#1103) - #2208
Merged
Merged
Conversation
Correct the HOPOPT and IPv6-Opts padding arithmetic: a well-formed options area is 2 octets short of a multiple of 8, not 6, and the counterfactuals in make and _make_pad_options now match the floor division make uses. Drop the bug-report 'are affected' from the R1_COUNTER width comment.
Owner
Author
|
Review: GOOD TO GO at
|
Owner
Author
|
Ready to merge at
|
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, round 6: the sixth whole-repo prose pass, covering
pcapkit/protocols/internet/with its schema, data and API pages.HOPOPTandIPv6_Opts.8k+6octets: two short of a multiple of 8, not six.(total_length - 6) // 8floor, a short area declares 2 octets fewer than it carries, not 6 more.[], 0emits the 2 fixed octets under aHdr Ext Lenof(0 - 6) // 8 == -1, not an 8-octet header.R1CounterParameter.countercomment says both codes take the eight octets, rather than that they "are affected".main.tests/project/test_docs_*plustest_conventions_doc_claims(104 passed). The HIP and IPv6-extension unit files, PadN/CALIPSO, the docstring contract and the tier guard all pass.