Repository navigation
docs(corekit): sixth whole-repo pass over corekit, const and vendor (#1103) - #2212
Merged
Merged
Conversation
…1103) - Rewrite change-relative narrative ("used to", "no longer", "before the fix", "this fix", "the old X", "final round") as timeless statements across corekit, the vendor crawlers and hand-written const prose. - Mirror the AppType, FTP Command and HTTP Method template prose edits into the committed const modules; only comments and docstrings differ. - Fix false prose: InfoMeta's __additional__ example order, a reversed zero-pad comparison in FieldBase.unpack, ConditionalField's condition argument, and FieldBase.__copy__'s "in this module".
Owner
Author
|
Review: GOOD TO GO at
|
Owner
Author
|
Ready to merge at
|
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, round 6: the sixth whole-repo prose pass over
pcapkit/corekit/,pcapkit/const/andpcapkit/vendor/.InfoMeta's__additional__example order. Measured:Bgives['c','d','a','b'].FieldBase.unpackcomment.ConditionalField'sconditionreceives the packet dict, not anInfo.ipx.socket_missing_note: it builds unregistered members.const/reg/apptype/apptype.py,const/ftp/command.pyandconst/http/method.py, as docs(vendor): fix AppType template prose and six crawler Args mismatches (#2175) #2180 did, with no regeneration.TransportProtocol's IntFlag base" (test_docs_internal_refs_1947_unit), and "value were both the bytes object" (test_const_method_value_lookup_908_unit).