[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• docs — documentation only

---

Description

Part of #1103, round 6: the sixth whole-repo prose pass over tests/protocols/, tests/vendor/, tests/const/ and tests/integration/.

• Change-relative narrative is stated as "Guards against…" or "Without the fix…". This covers review rounds, "Registries mint a permanent member for every unrecognised value: 1,169 extend_enum sites across 113 registries #775's final round", "PR 1/PR 2", "the old parser", "used to", and sha or date provenance.
• Codebase counts are removed, such as "45 of the 46" and "24 registered message types". Counts that explain an asserted literal stay, marked as measured.
• False claims corrected:
  • every PCAP-NG packet block loses its payload octets: packet is computed then overwritten with b'', so dumping through PCAPIO writes a record header claiming 314 octets followed by none #646: the unfixed file is 88 octets, not 104 (24 + 4×16). Measured by running a copy of the test against df23f7e6f^: it dumps 88 bytes, where main dumps 1400.
  • Stale entries: three references to EXPECTED_FAILURES entries that no longer exist.
  • Assertions, measured: the PCAP-NG NOTE in test_frame_length_runtime (every block carries its octets), and the SCTP BitField defect note (the probe passes).
• Scope: comments and docstrings only. With docstrings stripped, all 79 files have the same AST as main.
• Tests run: docs, conventions, issue-refs, tier guard and docstring contract give 249 passed. The changed const, vendor and integration files give 414 passed, and the changed protocols files 785 passed.
• Not changed, since they are code: change-relative test names, subTest labels and assertion messages. They are listed for a follow-up.

[JarryShaw]

Review: NEEDS CHANGES at bc0713f90 (Sonnet). No wrong claim was found, but commit-pinned evidence was dropped, which the round's rules keep:

• test_l2tp_data_export_1797_unit: the cdb5fef3f provenance.
• test_const_linktype_209_unit: the "Traced to cfdf2ab5c7" sentence.
• test_mh_unit: the 9b26fa387 reference.
• test_option_roundtrip_unit: the EXPECTED_FAILURES comment cut also took defect measurements. SMF_DPD 1100080100010100 gave len(schema) 3 against 4. RPL was 41 octets against the 48 its Hdr Ext Len declared, identical on 3.10.20 and 3.14.7. Restore them, or confirm the pinning tests already carry them.
• Verified: AST guard OK on 79 files, and 961 + 238 + 111 tests passed. every PCAP-NG packet block loses its payload octets: packet is computed then overwritten with b'', so dumping through PCAPIO writes a record header claiming 314 octets followed by none #646's 88 octets is correct (24 + 4×16). EXPECTED_FAILURES imports empty. The PCAP-NG and SCTP notes are accurate. No banned tokens remain.
• Follow-up, code, separate PR: assertNotEqual(len(dumped), 104) in test_pcapng_regression is vacuous; the broken size is 88.

[JarryShaw]

Review: GOOD TO GO at 85e6f513e (Sonnet delta review of bc0713f90→85e6f513e).

• Restored evidence: the cdb5fef3f, cfdf2ab5c7 and 9b26fa387 evidence is back, in timeless wording.
• test_option_roundtrip_unit:
  • RPL cites test_ipv6_route_rpl_fixed_area_is_four_octets, which carries 41 against 8 + 8 * 5 == 48.
  • SMF_DPD cites the null-TaggerID test and restores len(schema) 3 against 4, identical on 3.10.20 and 3.14.7.
• RPL caveat: it names fix(ipv6-route): compute Hdr Ext Len in 8-octet units on both sides #489 for the caveat and RPL schema's fixed area is 5 octets where RFC 6554 gives 4, so a built header is wider than its own Hdr Ext Len #564 for the header fix.
• Re-wraps: the word diff shows only comment markers, plus one accurate rewording in test_padding_kept_as_captured_unit.
• AST guard: OK on 79 files. No banned tokens in the delta.

[github-actions]

Coverage: 91.56% (unit tier, Python 3.15, 85e6f513e, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	881	2618	867	92.11%
pcapkit/corekit	2589	74	816	37	96.51%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	2994	23	1038	25	98.81%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17433	218	4584	185	98.15%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.

[JarryShaw]

Ready to merge at 85e6f513e. Part of #1103 (round 6).

• Review: Sonnet GOOD TO GO, after one NEEDS CHANGES round, which restored commit-pinned evidence.
• CI: all checks complete, Required checks passed SUCCESS, 0 failed.
• KTLO: 12 legs, no warnings.
• Ordering: merged into main and run. protocols: 1924 tests, const: 597 and vendor: 401, 0 failures.
• Conflicts: none against the current main.