Skip to content

docs(tests): sixth whole-repo pass over project, foundation, corekit and the remaining tests (#1103) - #2217

Merged
JarryShaw merged 1 commit into
mainfrom
docs/1103-r6-tests-b
Oct 26, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
docs/1103-r6-tests-b

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • docs — documentation only

Description

Part of #1103, round 6: the sixth whole-repo prose pass over every tests/ directory except protocols, vendor, const and integration: tests/project, foundation, corekit, cli, dumpkit, interface, toolkit, utilities and the root modules.

Prose only, in docstrings, comments and #: across tests/ outside
protocols/, vendor/, const/ and integration/:

- change-relative narrative ("before the fix", "as before", "since #NNN",
  "an earlier version", "round 3", "pre-#NNN") restated as current or
  conditional behaviour;
- counts of codebase items dropped (registrars, sentinels, sites, legs);
- third-party and in-repo file:line citations replaced by names;
- :issue: roles in tests/ restated as #NNN;
- stale claims corrected and wrapped paragraphs reflowed.

An AST comparison with docstrings stripped shows no code change.
@JarryShaw JarryShaw added docs Pull requests that change documentation only (docs: subject prefix) test Pull requests that add or correct tests (test: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 25, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Review: GOOD TO GO at b0721967b (Sonnet).

  • Accuracy: 13 large files and 8 sampled files were read in full, with no claim changed. "These properties" (four are listed), the ubuntu-latest and host-interpreter rewrites, and the pre-design: write down what belongs in the all extra, and why #910 and pre-fix seeds are all faithful.
  • Dropped unpinned counts: correct under the no-counts rule, and the conclusions stay. Re-derived: pcapkit/ has 2 Attribute raise targets and no Subscript. Commit-pinned measurements all survive (f4f94bcad, run 38325136710, job 118912680486).
  • AST guard: OK on 136 files. No banned tokens or :issue: roles in the added lines.
  • Tests: 74 non-project files give 1119 passed. The tests/project files give 1472 passed and 16 failed, with 4 errors. All the failures and errors are in five files that run workflow shell steps (gnu_timeout_2020, graalpy_shards_1963, resource_monitor_1740, superseded_runs_1938, sweeps_on_latest_only_1732). Those same failures and errors occur on origin/main on this host, so they are host-environment failures, not caused by this PR.
  • Not blocking: an awkward "from before ci: divide and simplify the workflows into scripts, shared heads and smaller files #1967" in test_ktlo_legs_stay_green_1672.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 25, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage: 91.56% (unit tier, Python 3.15, b0721967b, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 4 20 2 95.16%
pcapkit/const 19599 881 2618 867 92.11%
pcapkit/corekit 2589 74 816 37 96.51%
pcapkit/dumpkit 282 3 102 3 98.44%
pcapkit/foundation 2994 23 1038 25 98.81%
pcapkit/interface 138 4 52 3 96.32%
pcapkit/protocols 17433 218 4584 185 98.15%
pcapkit/toolkit 869 36 298 10 95.20%
pcapkit/utilities 504 7 146 5 98.15%
pcapkit/vendor 4432 1988 1018 167 51.87%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw

Copy link
Copy Markdown
Owner Author

Ready to merge at b0721967b. Part of #1103 (round 6).

  • Review: Sonnet GOOD TO GO, first round.
  • CI: all checks complete, Required checks passed SUCCESS, 0 failed.
  • KTLO: 12 legs, no warnings.
  • Ordering: merged into main and run. project: 2298 tests, foundation: 740 and corekit: 924, 0 failures.
  • Conflicts: none against the current main. ci(compat): compile the 3.8-floor util scripts on the 3.8 leg (#2206) #2214 shares test_ktlo_legs_stay_green_1672.py, and git merge-tree merges the two cleanly.

@JarryShaw JarryShaw added this to the PyPCAPKit v1.5 milestone Oct 26, 2026
@JarryShaw
JarryShaw merged commit 71f81ee into main Oct 26, 2026
66 checks passed
@JarryShaw
JarryShaw deleted the docs/1103-r6-tests-b branch October 26, 2026 03:12
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 26, 2026
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix) test Pull requests that add or correct tests (test: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant