[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• test — tests only

---

Description

Closes #2226. Three checks could not fail on main.

• test_dumped_pcap_carries_the_payload_octets: the vacuous assertNotEqual(len(dumped), 104) goes. The exact-size assertEqual above it is what catches every PCAP-NG packet block loses its payload octets: packet is computed then overwritten with b'', so dumping through PCAPIO writes a record header claiming 314 octets followed by none #646, and the comment says so. At df23f7e6f^ that assertion fails before the deleted line is reached.
• test_sctp_unit: the bitfield_packs_zero_bits probe and its skipTest are gone. With BitField.pre_process patched back to the old bug, main's copy skips and this one fails (True is not false).
• test_block2frame_puts_the_on_wire_length_in_len: adds assertEqual(frame.cap_len, len(frame.packet)) and drops the NOTE that excused it. With block2frame patched to return one octet short, main's copy passes and this one fails (314 != 313).
• Tests run: the three files give 54 passed, 0 skipped. test_chunk_flags_round_trip_with_mixed_bits now runs.

[JarryShaw]

Review: NEEDS CHANGES at 5ff243c5f (Sonnet).

• Still dead: assertNotEqual(len(dumped), 24 + 16 * len(expected)) cannot fail first. At df23f7e6f^, with this PR's tests, the record count (1 != 4) and the exact-size assertEqual above it fail earlier. It only fails (88 == 88) once those are stripped. Drop the line, as the issue allows; the assertEqual pins the size.
• Confirmed: the SCTP check. With BitField.pre_process patched back, it fails with True is not false.
• Confirmed: the cap_len check. With block2frame returning one octet short, it fails 6 subtests.
• Nothing else weakened. The three files plus the tier guard give 187 passed.

[JarryShaw]

Review: GOOD TO GO at 1e8c7f711 (Sonnet delta review of 5ff243c5f→1e8c7f711).

• Delta: only the still-dead size line goes, and the comment says the exact-size assertEqual catches every PCAP-NG packet block loses its payload octets: packet is computed then overwritten with b'', so dumping through PCAPIO writes a record header claiming 314 octets followed by none #646.
• Regression check: at df23f7e6f^, with the record assertions stripped, that assertEqual fails with 88 != 1400. So it does catch every PCAP-NG packet block loses its payload octets: packet is computed then overwritten with b'', so dumping through PCAPIO writes a record header claiming 314 octets followed by none #646. The record count (1 != 4) fails first.
• Tests: the three files plus the tier guard give 187 passed.

[github-actions]

Coverage: 91.56% (unit tier, Python 3.15, 1e8c7f711, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	881	2618	867	92.11%
pcapkit/corekit	2589	74	816	37	96.51%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	2994	23	1038	25	98.81%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17433	218	4584	185	98.15%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.

[JarryShaw]

Ready to merge at 1e8c7f711. Closes #2226.

• Review: Sonnet GOOD TO GO, after one NEEDS CHANGES round.
• CI: all checks complete, Required checks passed SUCCESS, 0 failed.
• KTLO: 12 legs, no warnings.
• Ordering: merged into main and run. protocols leg: 1924 tests, 0 failures.
• Conflicts: none against the current main.