Repository navigation
ci(timing): drop step and leg patterns no workflow emits (#2230) - #2240
Merged
Merged
Conversation
Problem: STEPS_OF_INTEREST kept a `3\.10 cell` alternative that no step matches since #1660 renamed it, and non_blocking still treated any job ending in ` (experimental)` as non-blocking, a rule only the unit-tests.yml legs that #1732 moved to experimental.yml needed. Fix: drop the alternative, EXPERIMENTAL_SUFFIX and its branch; an experimental leg is non-blocking through NON_BLOCKING_WORKFLOWS alone. workflows.rst says so. Test: test_every_step_of_interest_names_a_real_step requires each alternative of each pattern to match a step in .github/workflows/; test_a_blocking_leg_stays_hard asserts an (experimental) name in unit-tests.yml is blocking. LEGACY is gone.
JarryShaw
added
ci
Owner
Author
|
Review: GOOD TO GO at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— CI configurationDescription
Closes #2230.
util/ci_timing.py:3\.10 cellalternative, which matches no step in.github/workflows/.EXPERIMENTAL_SUFFIXand its branch innon_blockinggo, sinceNON_BLOCKING_WORKFLOWScoversexperimental.yml.non_blockingis nowworkflow in NON_BLOCKING_WORKFLOWS or job.endswith(KTLO_SUFFIX).test_ci_timing.py:LEGACYgoes.(experimental)case now asserts that such a job inunit-tests.ymlis blocking.test_every_step_of_interest_names_a_real_step, requires every pattern alternative to match a real step name.workflows.rst: the sentence saying an(experimental)job is non-blocking in any workflow now says it counts by its workflow.test_the_rule_is_documentedpins that sentence, and is updated with it.origin/main, 3 failed. The guard fails onRun the 3\.10 cell.*.test_ci_timinggives 71 passed. The floor, KTLO and matrix tests and the docstring contract give 148 passed. Theworkflows.rstreaders give 13 passed.