[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• fix — bug fix

---

Description

Closes #2223. HTTP._make_http_settings accepted a dict but always called settings.items(multi=True), which only MultiDict has, so {1: 2} raised TypeError: dict.items() takes no keyword arguments.

• Fix: it calls items(multi=True) on a MultiDict, OrderedMultiDict included, and plain items() otherwise. The annotation and Args: name a plain dict.
• Test: tests/protocols/application/test_httpv2_settings_dict_2223_unit.py.
  • {1: 2} and {Setting.HEADER_TABLE_SIZE: 2} build 000006040000000000000100000002, the same octets as the list.
  • Insertion order is kept, and the built frame parses back.
  • An empty dict builds an empty frame.
  • An OrderedMultiDict keeps repeated identifiers.
• Fail-without-fix: on origin/main, 5 failed with the TypeError.
• Tests run: tests/protocols/application gives 249 passed. The docstring contract and tier guard give 140 passed.

[JarryShaw]

Review: NEEDS CHANGES at 8e0d2872e (Sonnet).

• Tier marker: remove __tier__ = 'ALL'. tests/_tiers.py keeps ALL curated: interpreter-sensitive behaviour, round-trip tables and a smoke slice. This is a pure-Python construction regression test, and its sibling test_httpv2_settings_list_1140_unit.py carries no marker.
• Fix confirmed: {1: 2} builds 000006040000000000000100000002. MultiDict and OrderedMultiDict still use multi=True, and repeated ids build the same frame for both.
• Fail-without-fix: with main's httpv2.py, 5 failed with the TypeError. No other items(multi=True) site takes user input.

[JarryShaw]

Review: GOOD TO GO at 9ce7f89f7 (Sonnet delta review of 8e0d2872e→9ce7f89f7).

• Delta: only the __tier__ = 'ALL' marker and its comment are removed.
• Tests: the tier guard plus the new test give 138 passed. The earlier fix review stands.

[github-actions]

Coverage: 91.56% (unit tier, Python 3.15, 9ce7f89f7, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	881	2618	867	92.11%
pcapkit/corekit	2589	74	816	37	96.51%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	2994	23	1038	25	98.81%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17434	218	4584	185	98.15%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.

[JarryShaw]

Ready to merge at 9ce7f89f7. Closes #2223.

• Review: Sonnet GOOD TO GO, after one NEEDS CHANGES round, which dropped the ALL tier marker.
• CI: all checks complete, Required checks passed SUCCESS, 0 failed.
• KTLO: 12 legs, no warnings.
• Ordering: merged into main and run. protocols leg: 1929 tests, 0 failures.
• Conflicts: none against the current main.