Repository navigation
fix(traceflow): report the output path for open flows when the extension is empty (#2237) - #2246
Merged
Merged
Conversation
…ion is empty (#2237) TCP.submit guarded the open-flow fpout on a truthy extension, while _finalise checked `is not None`. A dumper registered with an empty extension writes `{root}/{label}`, so submit reported None for every open flow that _finalise later reported by path. Both now build fpout through TCP._output_path, which returns None only when the format writes no file. The Index.fpout docs say so. Test: test_an_empty_extension_reports_the_written_file_open_or_finalised reads fpout mid-capture and after finish.
JarryShaw
added
bug
JarryShaw
added
the
review: running
Owner
Author
|
Review: GOOD TO GO at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— bug fixDescription
Closes #2237. With a dumper whose extension is
'',TCP.submitreportedfpout=Nonefor open flows (if self._fdpext), whiletracehad written{root}/{label}and_finalise(is not None) reported it.TCP._output_path(label)helper returnsNoneonly when the format writes no file (NotImplementedIO).submitand_finaliseboth use it. Thefpoutdocs inIndexandtraceflow/tcp.rstmatch.test_an_empty_extension_reports_the_written_file_open_or_finalisedintests/foundation/traceflow/test_tcp.py. The file exists, andfpoutmatches it both mid-capture and afterfinish.origin/main,None != '/tmp/…/192.0.2.1_12345-198.51.100.2_443-1.25'.tests/foundation/traceflowgives 39 passed, the extraction tests 37 passed, and the docstring contract and tier guard 140 passed.