[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• test — tests only

---

Description

Closes #2227. These are the leftovers from #2248, in files other PRs owned at the time, plus three more hits from the issue's search. No assertion changes.

• Renamed:
  • test_case_sensitivity_from_896_still_holds → test_get_matches_names_case_sensitively
  • test_literal_is_now_a_role → test_each_curated_reference_is_a_role_not_a_literal
  • test_the_two_redundant_overrides_are_gone → test_the_mh_helpers_define_no_get_override
  • test_the_three_call_one_head → test_every_acting_workflow_calls_one_head
  • test_an_out_of_width_port_still_raises_764s_rejection → test_an_out_of_width_port_raises_while_an_unassigned_one_resolves
  • and seven more, one per commit-body line.
• Messages: in test_conventions_doc_claims.py, "no longer delegates", "no longer defines" and "no longer the union" now state the behaviour.
• References: the docstring and comment that named old tests are updated. No tier guard, KNOWN_* list or doc cites them.
• Left as is:
  • _still_ names in a control case beside a defect case ("still raises", "still pads"), which state behaviour by contrast;
  • spec quantities and fixture counts;
  • failure messages of the form "the page no longer states X", which name the regression a failure means.
• Tests: the 9 touched files give 307 passed. The tier guard, docstring contract and repo-wide text readers give 161 passed. Each renamed test passes under its new name.

[JarryShaw]

Review: GOOD TO GO at 7ceb58a18 (Sonnet reviewed c7474e284, and the delta was applied after its finding).

• Renames only: 12 renames in 9 files. No assert* call is added or removed, and each new name matches its test body.
• Old names: none remains in the repo. I also ran a multi-line search over tests/, docs/, util/, .github/ and pcapkit/ for every name test: name tests for the behaviour they check (#2227) #2248 or this PR retired, and it finds 0 hits.
• Delta: the review found one stale citation, a test_const_enum_no_mint.py docstring naming test: name tests for the behaviour they check (#2227) #2248's retired test_formerly_attributed_vendor_block_no_longer_mints split across two lines. It now cites test_an_attributed_vendor_block_does_not_mint.
• test: test names and messages describe changes, counts or the wrong behaviour #2227 completeness: every item the issue names is gone. A spot-check of 30 of the remaining _still_ and count hits found no change-relative names; they are control cases and spec quantities.
• Tests: touched files, the tier guard and the docstring contract give 447 passed. After the delta, test_const_enum_no_mint and the docstring contract give 75 passed.

[github-actions]

Coverage: 91.56% (unit tier, Python 3.15, 7ceb58a18, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	881	2618	867	92.11%
pcapkit/corekit	2589	74	816	37	96.51%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	3023	23	1044	25	98.82%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17434	218	4584	185	98.15%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.

[JarryShaw]

Ready to merge at 7ceb58a18. Closes #2227.

• Review: Sonnet GOOD TO GO, plus the wrapped-citation fix it found.
• CI: all checks complete, Required checks passed SUCCESS, 0 failed. It's a test-only diff, so the heavy matrices skip (ci: let docs-only and test-only pull requests skip the heavy matrices (#2243) #2244).
• KTLO: 3 legs, no warnings.
• Ordering: merged into main and run. project 2395, const 597, corekit 924, foundation 744 tests, 0 failures.
• Conflicts: none against the current main.