Repository navigation
Conversation
|
NEEDS CHANGES (Sonnet,
|
|
Held: Actions queue at 47 (above the hold line). The PR body and comment-width fix dispatches when the queue drops below 40. |
ANCHORS lacked the protocol-member-order page that the index toctree lists, failing test_the_index_toctree_lists_every_page_in_order.
6c27127 to
2e934cf
Compare
|
NEEDS CHANGES (Sonnet,
|
|
Owner ruling, paraphrased: the 15-line PR body limit is a recommendation, not a hard limit. The body length no longer blocks this PR. The local sibling commit |
|
GOOD TO GO (Sonnet, |
|
Decision needed: close this PR, or keep it. Options: (a) close it, since main |
|
take (a) |
|
Ruling applied: close this PR as redundant. Main |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visibleWhat is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseconst— regenerates constant or registry tables, members keeping their numeric valuesDescription of your pull request and other information
Adds
protocol-member-ordertoANCHORSintests/project/test_conventions_doc_claims.py, so the expected toctree matchesdocs/source/contributing/conventions/index.rst. The list stays strict, so a missing or extra entry still fails. Test-only, no changelog entry;make testwas not run in full andisortalready fails onmain.