Skip to content

refactor(application)!: move DRARP into its own module (#2529) - #2540

Open
JarryShaw wants to merge 1 commit into
mainfrom
refactor/2529-drarp-module
Open

JarryShaw wants to merge 1 commit into
mainfrom
refactor/2529-drarp-module

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else
  • const — regenerates constant or registry tables, members keeping their numeric values

Description of your pull request and other information

Part of #2529 (one protocol class per module, named after it).

A module holds one protocol class, named after it (owner ruling on #2529).

BREAKING CHANGE: DRARP moves from pcapkit.protocols.application.rarp to
pcapkit.protocols.application.drarp, and the old path keeps no re-export
(#1715, #1744). pcapkit.DRARP and pcapkit.protocols.DRARP are unchanged.

- rarp.py keeps RARP alone; RARP's dynamic DRARP alias is unchanged.
- Docs: new drarp.rst, versionremoved:: 1.6.0 on rarp, refs retargeted;
  the VLAN, C/S-Tag and L2TP docs and tests drop the per-index rule.
- Tests: the #1744 ledger takes a removal version; the reachability audit
  accepts a class inheriting its family base's __index__, not a shared
  module; new test_drarp_unit.py fails before the move.
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Coverage: 93.95% (unit tier, Python 3.15, 014a33dfa, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 4 20 2 95.16%
pcapkit/const 20087 144 2710 125 98.78%
pcapkit/corekit 2605 74 818 37 96.52%
pcapkit/dumpkit 281 3 100 3 98.43%
pcapkit/foundation 3194 27 1112 31 98.65%
pcapkit/interface 138 4 52 3 96.32%
pcapkit/protocols 19912 213 5236 207 98.32%
pcapkit/toolkit 924 36 334 10 95.55%
pcapkit/utilities 502 7 144 5 98.14%
pcapkit/vendor 5009 2222 1148 182 52.31%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw JarryShaw added breaking Breaks public-facing behaviour or API (apply alongside the type label) refactor Restructuring for its own sake — neither a fix nor a new capability (refactor: prefix) review: good-to-go Cross-review at the current head says ready; CI state is separate labels Nov 1, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Cross-review (Sonnet) at 623a19e41: every claim passed except the ftp_data contrast. The two-file delta at 014a33dfa that fixes it was checked locally, so the head is GOOD TO GO. It checked that pcapkit.DRARP and pcapkit.protocols.DRARP still resolve, that the old rarp.DRARP path is gone with no re-export, that RARP's dynamic alias is unchanged, and that the new test fails before the move.

@JarryShaw

Copy link
Copy Markdown
Owner Author

Re-ran Unit Tests (run 41289240031). Attempt 1 concluded success but never created the Required checks passed or Plain unittest ordering jobs, so the head had no required gate. Attempt 2 is running. The review verdict is unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaks public-facing behaviour or API (apply alongside the type label) refactor Restructuring for its own sake — neither a fix nor a new capability (refactor: prefix) review: good-to-go Cross-review at the current head says ready; CI state is separate

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

1 participant