Repository navigation
feat(link): bind LinkType 105 and 127 to the 802.11 and radiotap dissectors - #2632
Merged
Merged
Conversation
…ectors (#2608) - Frame.__proto__, PCAPNG.__proto__: IEEE802_11 (105) -> IEEE802_11 and IEEE802_11_RADIOTAP (127) -> Radiotap, in enum value order; docstring tables to match. - IEEE802_11.__index__ returns LinkType.IEEE802_11 rather than raising. - docs: 802.11 and radiotap pages name the native link types; the FCS note no longer assumes radiotap. - dispatch generator: payload builders and PINNED_TARGETS for both codes in both tables; the registry count pin follows. - tests: pcap and pcapng captures of each parse to 802.11 and Radiotap:802.11 with byte-exact rebuilds; fail without the change. Sample-capture differential matches main; pylint and mypy unchanged.
JarryShaw
added
feat
Owner
Author
|
GOOD TO GO at A Sonnet cross-review dumped Frame's and PCAP-NG's maps against
|
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…types and the registry split into 1.6.0 (#2449) - Breaking: Quick-Start values their fields cannot carry raise, reversing 1.5.0's round-down of a TCP rate under 80 kbps (#2630). - Folded into unreleased entries: tls12_cid records and DTLSContext (#2631), LinkType 105 and 127 in Frame and PCAP-NG (#2632), and DTLS.analyze_handshake behind dtls_handshake and packet (#2634). - Changed: foundation.registry.protocols split into per-layer submodules (#2635); 1.6.0's register_* roles and 1.5.0's three register_protocol* roles point at their submodules, 1.5.0's text unchanged. - The conventions entry records the per-layer wrapper placement (#2635) and parse ownership (#2634). No entry for #2629, which changes no released behaviour. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
feat— a new featureDescription of your pull request and other information
Frame and PCAP-NG now bind
LinkType.IEEE802_11(105) toIEEE802_11andLinkType.IEEE802_11_RADIOTAP(127) toRadiotap, inserted in enum value order (#2443). A native 802.11 or radiotap capture used to stayRawin both formats; it now parses to802.11/Radiotap:802.11and rebuilds byte-exactly.IEEE802_11.__index__returnsLinkType.IEEE802_11, following the owner's ruling on #2627 that__index__returns the standard registry value.Radiotap.__index__moves to 127 under #2627.examples/generators/dispatch.pygains a probe for each new binding, and the dispatch-case pin is re-derived.Both maps differ from
mainonly by the two added keys. All 23 sample captures parse identically; none of them carries link type 105 or 127, so the new test module is what covers the changed path. A Sonnet cross-review checked the frames against the 802.11 and radiotap layouts and returned GOOD TO GO.Closes #2608