Repository navigation
fix(protocols): re-export the DTLS connection-ID data and schema names - #2641
Merged
Merged
Conversation
JarryShaw
added
fix
Owner
Author
|
GOOD TO GO at |
This was referenced Nov 2, 2026
Merged
Merged
#2515) #2631 added DTLSCIDCiphertext (data and schema) and the TLS ConnectionId extension data to their submodules' __all__ but not to the packages, so test_every_package_reexports_every_child_export failed on main. - data.application: DTLS_CIDCiphertext, TLS_ConnectionId - schema.application: DTLS_CIDCiphertext - data and schema aggregators list the same names in __all__ Aliases follow the <protocol>_<name> form the siblings use (DTLS_Ciphertext, TLS_ExtensionData). The test is not tier-gated; it fails on 3.14 as well, and passes on 3.14 and 3.15 with this change.
JarryShaw
force-pushed
the
fix/reexport-dtls-cid
branch
from
November 2, 2026 08:14
4992765 to
63e4848
Compare
Owner
Author
|
Rebased onto On the old head, the only failure on |
This was referenced Nov 2, 2026
Contributor
|
Coverage: 94.08% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…shared value helpers into 1.6.0 (#2449) - Breaking: NoPayload and its data model and schema move from misc.null to misc.no_payload with no re-export, so a frame pickled by 1.5.x fails to load (#2636). 1.5.0's three NoPayload roles and 1.6.0's own point at misc.no_payload, 1.5.0's text unchanged. - Added: the IP, L2TP, ICMP, IGMP and LinuxSLL bases give a member on read, make and from_data, version= naming it, with the refusals and IPv4's Version check ahead of the header (#2639). - Changed: SCTP's chunk-flag and Invalid Stream Identifier reserved-octet messages (#2638). Folded into the TLS/DTLS entry: make() raises StructError for a value too wide for its field (#2638), and the DTLS_CIDCiphertext and TLS_ConnectionId package exports (#2641). - The conventions entry records the version= dispatch rule (#2639) and ARP as the member-order reference (#2638). - No entry for #2638's private value helpers or the Ethernet and PCAP-NG PAT_MAC_ADDR, as for #1844's OSPF copy; #2640's docstring fixes; or the test-only #2620, #2637, #2645 and #2646. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— a bug fixDescription of your pull request and other information
mainfailstests/protocols/test_package_reexports_1807_unit.pyon every Python. It shows on thePython 3.15leg, and fails locally on 3.14 as well. #2631 addedDTLSCIDCiphertext(data and schema) andConnectionId(data) to their submodules'__all__without re-exporting them from the application packages.This adds the package re-exports under the aliases the siblings use,
DTLS_CIDCiphertextandTLS_ConnectionId, plus the matching__all__entries inpcapkit.protocols.dataandpcapkit.protocols.schema. The re-export test passes on 3.14 and 3.15, as do the public-API,__all__-export, layer-grouping and moved-name guards. It is 9 lines across 4__init__.pyfiles.