Combind job store trd 85 - #3
Merged
Merged
Conversation
Added the persist package of UWS to the hibernate objects in application.properties for UWSJobEntity visibility
Same for the service object used on the sync methods as they exist in their own right (due to the Uni launching the create job on a separate thread)
# Conflicts: # src/main/java/org/javastro/ivoa/tap/AsyncQueryResource.java # src/main/java/org/javastro/ivoa/tap/QueryResource.java
…ons) due to the changes to hide most of the operations from the TapServer. Added the transactional overridden methods to the sync base class for the same reason. Sync approach requires a custom bean that can be indexed due to Uni moving the actual createJob call to a different thread
Contributor
Author
|
Build failed due to the new version of ivoa core not being reviewed and deployed yet. |
Member
|
I think that this is ok despite the failed builds on GitHub - caching probably responsible |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated some of the calls in both async and sync due to @transactional being required.