Repository navigation
Conversation
35 real device and app UAs were flagged because a substring of a model or app name hit a pattern: - Cronet, Chrome's network stack, which Android and iOS apps such as Google Go and TikTok name in their UA, hit "cron" in the catch-all. - VR BOT 552, XBot_Senior and M_bot_tab phones hit "bot". - Banca Caboto (a bank's IE build) hit "bot", TIANYU-KTOUCH hit NYU, DESAY TS1008/ hit 008/ (80legs), AmigaVoyager hit voyager/, and Yandex.Music hit Yandex. Add each name to the device and app section of Exclusions, the same way cubot is handled, and add the 35 UAs to devices.txt. Also remove the speedy pattern, which flagged a Speedy phone and an app of that name. Every Speedy Spider UA also contains "spider", so the catch-all still detects all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #639.
35 real device and app UAs were flagged as crawlers because part of a model or app name hit a pattern:
Cronet(Chrome's network stack, named in the UA by Android and iOS apps such as Google Go and TikTok)cronin the catch-allVR BOT 552,XBot_Senior,M_bot_tab_…phonesbotSpeedyphones and appspeedyBanca CabotoIE build,TIANYU-KTOUCH,DESAY TS1008/1.0,AmigaVoyager,Yandex.Musicbot,NYU,008\/,voyager\/,YandexFix
Exclusions.php, the same waycubotis handled. They're plain literals, so nothing changes for the ports.speedypattern is removed rather than excluded. Every Speedy Spider UA incrawlers.txtalso contains "spider", so the catch-all still detects all eight. A narrowerSpeedy ?Spiderpattern would trip the collision test for the same reason.devices.txt. They're all flagged on master and none are with this change. Every line incrawlers.txtis still detected.This doesn't settle the broader #639 question about the catch-all matching inside words. It only fixes the cases seen in real UAs.