Repository navigation
Conversation
Add 32 signatures: - Link previews and social fetchers: Bluesky, Meta (Meta-ExternalHit, meta-externalads), Snapchat, Viber, KakaoTalk, Steam chat, Notion, ClickUp, Yahoo's link expander, OpenGraph.io, Shareaholic, FediList, Friendica, Zendesk webhooks, Workona's favicon service, and the Rambler and Ukr.net mail image proxies. - Google fetchers that weren't covered: Google-Lens, Google-Safety, Google-CWS, Google-ilp, Google-Assess, Google-Shopping-Quality, Google-Sites-Thumbnails, Google-BusinessLinkVerification, GoogleAdSenseInfeed and Google-Cloud-Scheduler. - Naver Japan and vuhuv search crawlers.
The desktop app is Electron and sends Notion/x.y in its UA, so Notion\/[0-9] would flag people using it. Require the (https://notion.so part that only the fetcher sends, and add a desktop app UA to devices.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 32 signatures, with 33 test UAs, for fetchers that
isCrawler()currently misses.Bluesky Cardyb,bluesky-domain-status-classifier,Meta-ExternalHit\/,meta-externalads,Snap ?URL ?Preview,ViberUrlDownloader,kakaotalk-scrap,SteamChatURLLookup,SteamChatImageProxy,Notion\/[0-9.]+ \(https:\/\/notion\.so,ClickUpLinkUnfurler,Yahoo:LinkExpander,OpenGraph\.io,Shareaholic,FediList Agent,Friendica,Zendesk Webhook,workona-favicon-serviceImageProxy\/(Rambler),secureurl\.fwdcdn\.com(Ukr.net)Google-Lens,Google-Safety,Google-CWS,Google-ilp,Google-Assess,Google-Shopping-Quality,Google-Sites-Thumbnails,Google-BusinessLinkVerification,GoogleAdSenseInfeed,Google-Cloud-SchedulerNaverJapan,vuhuvRBTNotes:
Notion/x.yin its UA too, so the pattern requires the(https://notion.sopart that only the link-preview fetcher sends. A desktop app UA is added todevices.txtto keep it that way.Chrome/W.X.Y.Zin place of a real Chrome version, as it appears in the published string.devices.txtmatch any of the new patterns.