Skip to content

give BenchmarkTimer a warmup #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-dilks merged 3 commits into from
Sep 25, 2026
Merged

give BenchmarkTimer a warmup #1453

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5c1202
give benchmarks a warmup too
baltzell Sep 24, 2026
25fe25b
fix div-by-zero protection
baltzell Sep 24, 2026
0dce884
warmup-correct #calls in printout
baltzell Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions common-tools/clas-utils/src/main/java/org/jlab/utils/benchmark/BenchmarkTimer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
*/
public class BenchmarkTimer {

private static final int WARMUP_CALLS = 100;

public static class BenchmarkMultiTimer extends BenchmarkTimer {
ConcurrentHashMap<Integer,Long> timeAtResume = new ConcurrentHashMap<>();
ConcurrentHashMap<Integer,Boolean> isPaused = new ConcurrentHashMap<>();
Expand All @@ -23,8 +25,8 @@ public void resume(int thread) {
}
public void pause(int thread) {
if (!isPaused.get(thread)) {
numberOfCalls.incrementAndGet();
totalTime.addAndGet(System.nanoTime() - timeAtResume.get(thread));
if (numberOfCalls.incrementAndGet() > WARMUP_CALLS)
totalTime.addAndGet(System.nanoTime() - timeAtResume.get(thread));
isPaused.put(thread, true);
}
}
Expand Down Expand Up @@ -62,8 +64,8 @@ public void resume(){

public void pause(){
if(isPaused==false){
totalTime.addAndGet(System.nanoTime() - timeAtResume);
numberOfCalls.incrementAndGet();
if (numberOfCalls.incrementAndGet() > WARMUP_CALLS)
totalTime.addAndGet(System.nanoTime() - timeAtResume);
isPaused = true;
}
}
Expand All @@ -84,13 +86,13 @@ public double getSeconds(){
}

public double getMillisecondsPerCall() {
return numberOfCalls.get() > 0 ? getMilliseconds() / numberOfCalls.get() : 0;
return numberOfCalls.get() > WARMUP_CALLS ? getMilliseconds() / (numberOfCalls.get() - WARMUP_CALLS) : 0;
}

@Override
public String toString() {
return String.format("%-15s : #Calls %12d, Total = %12.2f sec, Unit = %12.3f msec",
getName(), numberOfCalls.get(), getSeconds(), getMillisecondsPerCall());
getName(), numberOfCalls.get()-WARMUP_CALLS, getSeconds(), getMillisecondsPerCall());
}

}
Loading