Conversation
yugotra
requested review from
baltzell,
c-dilks,
raffaelladevita,
tongtongcao and
zieglerv
as code owners
September 28, 2026 15:51
Collaborator
|
Currently, the track propagation in the magnetic field is done with the swimmer. Therefore the changes to the helix-based propagation would have no effect. The change that may be critical is the check on the matrix H. What problem was found with the swimmer? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
At 5 T, the numerical CVT Kalman projector returned perturbed helix states to simplified detector surfaces. For aligned SVT sensors it intersected only the plane trace in x-y and discarded the plane normal's z component. For aligned BMT layers it intersected a cylinder centered on the beam axis instead of the displaced and tilted geometry axis. The projector therefore differentiated a different measurement geometry from the geometry used by normal state transport.
This explains why the main SVT failure was absent for ideal-geometry MC and 0 T data: ideal SVT planes have no omitted longitudinal tilt, while the 0 T straight-track path already uses the full plane intersection.
Change
The state still swims through the field map while the projector uses an analytic uniform-field helix. This change corrects the detector-surface geometry used by that analytic projector; it does not make the projector field-map exact. The swimmer-based projector was tested and performed worse because finite differences amplify swimmer noise.
Validation
HelixTest: 8 tests passed.beamSpotConst=2: valid covariance 87.39% -> 94.93%; SVT residual width 109.76 -> 54.89 um; layerwise widthcos(2phi)amplitude 29.8-66.5 -> 0.14-1.91 um.The unrelated covariance-reporting correction and the broader swimmer-recovery policy change are intentionally excluded from this branch.