Skip to content

lower lock for detector-changed hook #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-dilks merged 1 commit into from
Sep 30, 2026
Merged

lower lock for detector-changed hook #1467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions common-tools/clas-reco/src/main/java/org/jlab/clas/reco/ReconstructionEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ public abstract class ReconstructionEngine implements Engine {
abstract public boolean init();
abstract public void detectorChanged(int runNumber);

final Object detectorChangedLock = new Object();

public ReconstructionEngine(String name, String author, String version){
engineName = name;
engineAuthor = author;
Expand Down Expand Up @@ -345,16 +347,18 @@ public void dropBanks(DataEvent event) {
}
}
}
public synchronized boolean checkRunNumber(DataEvent event) {

public boolean checkRunNumber(DataEvent event) {
int r = runNumberOverride;
if (r <= 0 && event.hasBank("RUN::config")) {
r = event.getBank("RUN::config").getInt("run",0);
}
if (r > 0) {
if (this.runNumbers.isEmpty() || r != this.runNumbers.get(this.runNumbers.size()-1)) {
this.runNumbers.add(r);
this.detectorChanged(r);
synchronized (detectorChangedLock) {
if (this.runNumbers.isEmpty() || r != this.runNumbers.get(this.runNumbers.size()-1)) {
this.runNumbers.add(r);
this.detectorChanged(r);
}
}
}
return !this.ignoreInvalidRunNumbers || r>0;
Expand Down
Loading