Skip to content

ECAL mcsmear - #414

Merged
staylorjlab merged 2 commits into
masterfrom
ecal_simu
Sep 14, 2026
Merged

ECAL mcsmear#414
staylorjlab merged 2 commits into
masterfrom
ecal_simu

Conversation

@somovalex

@somovalex somovalex commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

  • Add simulation of the energy threshold.

  • Exclude modules listed in the /ECAL/bad_block CCDB table
    (these modules will also be excluded in DECALHit_factory).

Alexander Somov
- Add simulation of the energy threshold.
22aef70 
- Exclude modules listed in the /ECAL/bad_block CCDB table
(these modules will also be excluded in DECALHit_factory).
@gluex

gluex commented Sep 3, 2026

Copy link
Copy Markdown

Test status for this pull request: SUCCESS

Summary: summary.txt
Logs: results/log

Build log: make_ecal_simu.log
Build report: report_ecal_simu.txt

somovalex
somovalex commented Sep 14, 2026
View reviewed changes

@somovalex somovalex left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks Ok

@staylorjlab

staylorjlab commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

I confirmed that the threshold is being applied on some particle gun simulated data.

staylorjlab
staylorjlab approved these changes Sep 14, 2026
View reviewed changes

@staylorjlab staylorjlab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works.

@staylorjlab
staylorjlab merged commit 9351512 into master Sep 14, 2026
1 check passed
@aaust aaust mentioned this pull request Sep 17, 2026
Closed
@gluex

gluex commented Sep 17, 2026

Copy link
Copy Markdown

Test status for this pull request: SUCCESS

Summary: summary.txt
Logs: results/log

Build log: make_ecal_simu.log
Build report: report_ecal_simu.txt

@gluex

gluex commented Sep 17, 2026

Copy link
Copy Markdown

Test status for this pull request: FAILURE

Failures: failures.txt
Summary: summary.txt
Logs: results/log

Build log: make_ecal_simu.log
Build report: report_ecal_simu.txt

@gluex

gluex commented Sep 17, 2026

Copy link
Copy Markdown

Test status for this pull request: FAILURE

Failures: failures.txt
Summary: summary.txt
Logs: results/log

Build log: make_ecal_simu.log
Build report: report_ecal_simu.txt

@aaust

aaust commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The pull-request test would have caught it, wasn't it for a small typo

@somovalex

somovalex commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

I will check and correct it tomorrow, it's related to the run range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staylorjlab staylorjlab staylorjlab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@somovalex @gluex @staylorjlab @aaust