Repository navigation
Add watchOS and tvOS targets - #159
AJ Alt (ajalt) wants to merge 1 commit into
Conversation
|
Can we consider this? We're also stuck on this. |
|
Why do you need these targets? Can it be enough to build the source code against them locally? |
|
Hey Peter, thanks for the quick reply 🙂 We're working on a Markdown foundation for our iOS and watchOS apps, and I think using this library in a shared KMP module would be the best option for us. The problem is that without the device targets ( Building from source would work, but it means keeping a fork and publishing it ourselves, which I'd rather avoid. Right now this is what makes us choose between this library and writing our own native parser. |
|
Here's an AI analysis. To be able to run CI, this should probably be rebased onto This PR shouldn't be merged as it stands. The target declarations are fine, but the new targets are missing from the publishing setup. A release from this branch would probably fail Maven Central validation, and that would block the whole release. What the PR does
Blocking issue The new targets aren't added to publicationsToArtifacts (build.gradle.kts). Only names on that list go through registerPublicationFromKotlinPlugin (which attaches javadocJar and the POM details: license, developers, scm) and signPublicationsIfNecessary; see publication.kt. The Kotlin plugin will still create publications for the six new targets, such as markdown-watchosarm64. But they'll go into the artifacts bundle with no signature, no javadoc jar and a bare POM. Central Portal rejects a bundle like that, so publishMavenToCentralPortal would fail for the whole release, not just for these targets. The fix is to add these six entries to the list: "watchosArm32" to "markdown-watchosarm32", Ideally, build both target lists (declarations, nativeSourceSets) and the publication map from one shared list, so the three can't drift apart again. This bug happened exactly because they did. Unverified CI risks
Fine as is
Nits
|
2f3e94b to
58bd653
Compare
|
I pushed a new commit that addresses all the review comments |
This library currently only publishes for the simulators for watchOS and tvOS. This PR adds the remaining targets for those platforms.