Repository navigation
fix(onboarding): login ownership, hermetic smoke:logins, and cancellable account detection (#949) - #978
Merged
Olga Lavrichenko (OLavrik) merged 1 commit intoOct 28, 2026
Conversation
… smoke:logins hermetic, and stop account detection from stacking hung reads (#949)
Olga Lavrichenko (OLavrik)
requested review from
Rustam Sadykov (SBOne-Kenobi),
danyaberezun and
Rinat S (rsolmano)
as code owners
October 28, 2026 09:38
Olga Lavrichenko (OLavrik)
deleted the
fix/onboarding-login-robustness-949
branch
October 28, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #949. Follow-up to #808: the three robustness problems the review split out.
1. In-app login ownership
startReservedLogin). If the connect surface closes or Skip is pressed beforeprovider.loginStartanswers, the returnedloginIdis cancelled and cleared instead of running hidden with no UI.clearSettledLogin(providerId)), so it can no longer drop a newer login.clearLogin(loginId?)clears only the named login when an id is given.errorframe for the supersededloginId(so another client stops sitting on "Working…") and callsdropLoginvia anonSupersededcallback, so the analytics entry no longer leaks.unheldLoginFrameonly so a client's own fast failure can still surface when its start response lands.2. Hermetic
smoke:loginscwd: sandbox,--no-env-fileandtoolHomeEnv(sandbox home)from@thinkrail/shared/toolHomes, so neither the repo-root.envnor a real tool home leaks in (USERPROFILEis now set).authUrl/deviceCode/prompt; an immediatesuccessand a run with zero outcomes now fail.rmSync.3. Cancellable account detection
detectAccounts(the host, argument-less call) is single-flight, and a read still pending for a path is reused until it settles, so repeated detection over a hung mount no longer stacks file-system operations.Tests
bun run smoke:logins: 56/56 flows reached their first sign-in step.bun run e2e(all 8 shards), unit tests, and all fast gates pass.