Skip to content

Add versioned notation and source-boundary fidelity metrics without rewriting historical scores #14

Closed

Description

@CompleteDotTech

Problem and observed evidence

The current scorer strips nonalphanumeric characters before comparison. It assigns perfect precision, recall and boundary agreement to these materially different expressions:

  • x = 1 versus x != 1
  • x + y versus x - y
  • 10^5 versus 105

This proves a metric blind spot; it does not establish a notation error in every accepted paper. The frozen v2 baseline has 91 historical text98 successes but 90 historical boundary-plus-text98 successes: f195 appends an extra final footnote marker. The prose in the public report must distinguish these definitions.

Code entry points

Required implementation

  1. Preserve the legacy text_match_98 and boundary_and_98_match definitions and historical receipts under explicit metric versions. Add separate metrics instead of silently changing their meaning.
  2. Define notation-aware comparison preserving meaningful operators, negation, superscript/subscript structure, signs, units and equation order. Specify permitted normalization (for example reviewed Unicode/font-equivalent forms) with positive and negative fixtures. Do not claim semantic equation equivalence from punctuation stripping.
  3. Measure boundaries against source-reviewed start/end spans or image regions and section ownership; surface extra prefix/suffix material, footnotes, metadata and body contamination independently from approximate text agreement.
  4. Represent notation and boundary review as pass/fail/unresolved/not-applicable with attributed evidence. Separate source location, transcription fidelity and review status. Unresolved scientific notation must not count as verified correct.
  5. Extend summaries with metric-version identifiers, eligible denominators, false proposals, complete-abstract recall, reading-order and notation errors, review workload, and skipped/unresolved cases. A matching withheld candidate remains withheld.
  6. Correct the public report's 91-versus-90 explanation without changing the historical dataset or lowering the 98% threshold. Correct f195's output in the selector/boundary work and measure the improvement here.

Reproduction

A minimal synthetic demonstration, with no private data required:

python -c "from trace_gc.pdf_source_parallel_v4 import compare; print(compare('x = 1', 'x != 1')); print(compare('10^5', '105'))"
python -m unittest discover -s tests -p 'test_parallel_source*v4.py' -q

After implementation, run versioned metric tests and the integrated 200-paper gate; retain both legacy and new results for every case.

Acceptance criteria

  • The three counterexamples above fail notation fidelity even when historical text98 remains true.
  • Meaning-preserving rendering/whitespace differences allowed by the documented policy pass; sign, exponent, equation-order and unit changes do not silently pass.
  • Authored contamination tests distinguish exact abstract boundaries from approximate text success.
  • Frozen v2 remains 91 legacy text98 / 90 legacy boundary-plus-text98; f195 is explicitly traceable without publishing its paper text.
  • Unresolved notation and missing review evidence remain visible and cannot be reported as certified fidelity.
  • Full 200-case summaries retain absent/partial/error/withheld denominators and metric identities; an all-abstain selector cannot appear to have perfect measured coverage.
  • Historical receipts remain byte-preserved; updated documentation names the evaluated property rather than implying scientific fidelity.

Research informing the design

olmOCR-Bench's tests separate text, ordering and mathematics; OmniDocBench evaluates document components separately. These are implementation patterns, not evidence that TRACE-GC already passes.

Private evidence: an authorized maintainer can resolve validation_v3_private/diagnosis-20260928/receipt-audit.json and ROOT_CAUSE_AND_SOLUTIONS.md beneath the external test-data root. Latest results.json SHA-256: 661964b8db10bf2bd806a95a0119f4492dcabf72e759fff521993f702f016b0d; historical: f9ee4f438c8cae7ce192970f7ff172ecbe7c24b3a383d48fe62cf75da7f4102b. Obtain authorized local access to PDFs, frozen labels, converter caches and the f001–f200 relative source map following the reproduction guide. Keep those assets and full assessments outside the public repository; publish only redacted aggregate results and hashes. Missing access is a blocked quality run, not a passing substitute.

Scope

Metric implementation can proceed independently of selector repairs. Use versioned/additive evaluation so alignment behavior is not accidentally changed by replacing a shared canonical() helper.

Tracking and completion dependencies

Parent: #12. Milestone: Paper extraction and GraphRAG qualification.

No mandatory issue prerequisites; implementation can begin using the documented inputs.

Required by: #18, #19.

Activity

  1. added
    bugSomething isn't working
    area:qualityConformance, security, replay, and evaluation
    initiative:paper-graphragPaper extraction, evidence admission, retrieval and real GraphRAG qualification
    priority:P1Required to repair known correctness failures or make acceptance evidence trustworthy
    on Sep 28, 2026
  2. CompleteDotTech commented on Sep 28, 2026

    @CompleteDotTech
    CollaboratorAuthor

    Implementation PR: #24 (signed head 0209c5be50e4a82c0d9cf3ec00ee9c327d6f7468). Independent code rereview cleared the metric fixes. The private 1,000-assessment rescore preserved legacy results; public aggregate receipt is in the PR. Hosted CI is pending. Typed independent source review, f195 selector correction, the integrated 200-paper gate, and unseen qualification remain outstanding, so this issue stays open after the implementation merge.

  3. CompleteDotTech commented on Sep 28, 2026

    @CompleteDotTech
    CollaboratorAuthor

    Acceptance audit complete for the additive fidelity-metric scope. The merged implementation and separate reviewer reproduce all three notation blind spots, allowed rendering equivalences, contamination distinctions and all-abstain handling (30 focused tests passed). The frozen historical scorer and 1,002 rescore input hashes are unchanged: v2 remains 91 legacy text98 successes and 90 boundary-plus-text98 successes. f195's current saved-native primary extent excludes its terminal marker; the source-reviewed supplement binds the exact native identity and independently passes source location, transcription/notation, reading order and boundary checks.

    On merged d7af957, the sealed 200×4 saved-native report SHA-256 0cfb07240426c5df4de077d6ae1091d28e0a2721558724da91ff1f55d75c19ec has 200 distinct cases per arm and preserves all absent/partial/error/withheld denominators and metric versions. All 800 raw assessment seals and per-case metric summaries were recomputed in review. Every missing source review remains unresolved; verified-fidelity count is zero, so no scientific-fidelity or extraction-quality success is inferred. Primary preservation still FAILS (77 correct, zero false, 18 of the historical 91 lost). These are #17/#19 gates; unseen #20 and real pilot #23 also remain open. The owner's independent-human waiver is reflected as internally attributed review only.

    The seven #14 acceptance checkboxes are marked complete. Closing this metric-delivery issue does not promote the selector or qualify the corpus. The fresh-native #19 run and image-enabled acceptance receipt remain separate work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:qualityConformance, security, replay, and evaluationbugSomething isn't workinginitiative:paper-graphragPaper extraction, evidence admission, retrieval and real GraphRAG qualificationpriority:P1Required to repair known correctness failures or make acceptance evidence trustworthy

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions