Repository navigation
Conversation
…ata, fix ProfileData constructor Co-authored-by: mthielma <1148509+mthielma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement profile processing improvements as per PR #215
Fix profile extraction: stop merging volume data, initialise all ProfileData fields
Oct 2, 2026
Contributor
|
Copilot went a bit too far here, as it started to fix all kinds of issues, not only the one I asked for. I am therefore also closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile processing should take volume datasets as a named tuple and not merge them into one grid first, which is slow when there are many volume datasets. It also needs to pass topography data through and keep
ProfileData.TopoDatausable.Most of this was already in place (
TopoDatafield, named-tuplecreate_profile_volume!, topo arguments onextract_ProfileData!). Two gaps remained:ProfileDataconstructornew(...)was given 7 values for a 9-field struct, soTopoData,PointDataandScreenshotDatawere left undefined on a fresh profile.nothing.profile.TopoDataorshow(profile)fails on an unset field.extract_ProfileData(file, n, datasetfile)convenience wrappercombine_vol_data.NamedTupleof volume datasets straight toextract_ProfileData!, so each dataset is cross-sectioned on its own.TopoDataandScreenshotData, whichload_GMGalready returned but the wrapper dropped.Notes for review
TopoDatais empty on a freshProfileData. Topography extraction itself is not covered.test/test_ProfileProcessing.jlmay not match any current method. They passnothingas the volume data, and pass screenshot data as a fifth positional argument. I left them unchanged.