Skip to content

Use GraphsInterfaceChecker.jl in the test suite - #14

Open
Max0nyshchenko wants to merge 3 commits into
JuliaGraphs:masterfrom
Max0nyshchenko:feature/use-graphsinterfacechecker
Open

Use GraphsInterfaceChecker.jl in the test suite#14
Max0nyshchenko wants to merge 3 commits into
JuliaGraphs:masterfrom
Max0nyshchenko:feature/use-graphsinterfacechecker

Conversation

@Max0nyshchenko

Copy link
Copy Markdown

Solves #3

@codecov

codecov Bot commented Dec 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.46%. Comparing base (8be0b30) to head (e24d250).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/VNGraphs.jl 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
+ Coverage   45.90%   67.46%   +21.56%     
===========================================
  Files           1        1               
  Lines          61       83       +22     
===========================================
+ Hits           28       56       +28     
+ Misses         33       27        -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov Krastanov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a very helpful contribution! I have a small suggestion for improving the tests. Could you look into it?

Comment thread test/test_consistency.jl Outdated
@test VNGraphs.graph_chromatic_number(g,0)==3

@testset "Graphs.jl Interface Check for VNGraph" begin
vngs = [VNGraph(12), VNGraph(20), VNGraph(5)]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a few random graphs too? If I am reading this correctly, currently it is being tested only on empty graphs. Something like VNGraph(Graphs.whatever_random_graph_generator(...))

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense, thank you. I will do that and keep you updated, might take some time for me as I'm not that familiar with these libs (Graphs, VNGraph and VN in C).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please feel free to check.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krastanov, please feel free to check

@Max0nyshchenko

Copy link
Copy Markdown
Author

@Krastanov — following up on this one. I added the random-graph cases you suggested back in December, so test_consistency.jl now covers generated graphs rather than only empty ones. I think it's ready for another look whenever you have time.

The check results shown here are from the original December run and are stale — happy to rebase onto current master for a fresh run if that would be useful.

No rush, and thanks again for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants