Add MPI.Win_allocate - #987
Open
jack-dunham wants to merge 1 commit into
Open
jack-dunham wants to merge 1 commit into
jack-dunham wants to merge 1 commit into
Conversation
vchuravy
reviewed
Sep 21, 2026
| `disp_unit` is `sizeof(T)`, so the `disp` argument of [`MPI.Get!`](@ref) and | ||
| [`MPI.Put!`](@ref) counts elements. | ||
|
|
||
| `infokws` are info keys providing optimization hints. |
Member
There was a problem hiding this comment.
We would still just call them kwargs...
vchuravy
reviewed
Sep 21, 2026
Comment on lines
+110
to
+112
| # the ptr may be invalid for a zero-size window, which will cause an error as | ||
| # unsafe_wrap checks the alignment of ptr, even for length 0 | ||
| array = len > 0 ? unsafe_wrap(Array, ptr, dims) : Array{T}(undef, dims) |
Member
There was a problem hiding this comment.
That error kind would also be true for Win_allocate_shared
vchuravy
reviewed
Sep 21, 2026
| # External links | ||
| $(_doc_external("MPI_Win_allocate")) | ||
| """ | ||
| function Win_allocate(::Type{Ptr{T}}, len::Integer, comm::Comm; infokws...) where T |
Member
There was a problem hiding this comment.
We should check if T is pointerfree and inlinealloc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
MPI_Win_allocate, the one window constructor in the standard that MPI.jl did not yet expose.API.MPI_Win_allocateis already generated insrc/api/generated_api.jl; this adds the high-level interface beside its siblings insrc/onesided.jl.Full disclosure, I am not an expert in MPI, and this code was generated by Claude by pointing it to the existing
MPI.Win_allocate_sharedimplementation, but the output seems reasonable to me. If it is not, consider this a feature request with a first attempt at a solution.