Android: build:android establishes its own precondition - #195
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root
build:androidran the port's build without establishing what that build needs, so a freshclone produced an APK that crashed on the device instead of failing at build time.
Two separate gaps, both measured:
@learn6502/corewas not built. The port's build needs it; a session had to rungjsify workspace @learn6502/core buildby hand to get an APK at all.--with-dependenciesfixes this one, and
start:androidnow builds before it starts.@learn6502/learnwas never declared a dependency ofapp-android— even thoughlearn'sown
buildcopies its generatedtutorial.ns.xmlandquick-help.ns.xmlstraight intoapp-android/app/mdx/. That relationship is a FILE COPY across a workspace boundary, not animport, so it is invisible to module resolution and to
--with-dependencies. The APK builtsuccessfully with an empty
app/mdx/and only crashed on-device when opening the tutorial.The second one is the reason this is worth a note in AGENTS.md rather than just a script edit: a
build-graph edge that no import expresses cannot be derived, so it has to be declared.
Found while chasing the hex-monitor fix (#193), where the missing build showed up as a runtime
crash rather than a build failure.
Checked:
check-workspace-scriptsgreen, both manifests parse, build byproducts kept out of thecommit.
🤖 Generated with Claude Code