Repository navigation
feat: auth-gate webhook verify, constrain cache delete regex, validate admin id routes, and sanitize logs - #1651
Open
bitcoindev817-hue wants to merge 1 commit into
Conversation
…e admin id routes, and sanitize logs - Issue Junirezz#1608: Auth-gate /webhooks/verify endpoints with dedicated limiter and secret protection - Issue Junirezz#1609: Constrain regex pattern and add dry-run to DELETE /admin/cache - Issue Junirezz#1610: Validate params on admin id routes and handle malformed URI decoding - Issue Junirezz#1612: Fully mask secrets in diagnostics bundle and redact wallet addresses in logs Closes Junirezz#1608, Closes Junirezz#1609, Closes Junirezz#1610, Closes Junirezz#1612
|
@bitcoindev817-hue Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issues #1608, #1609, #1610, and #1612:
Auth-gate /webhooks/verify endpoints ([backend] Remove or auth-gate public /webhooks/verify endpoints that sign caller-supplied secrets #1608)
ApiKeyauthentication withwebhooksscope for both/webhooks/verifyand/api/v1/webhooks/verify.Constrain user-supplied regex on DELETE /admin/cache ([backend] Constrain user-supplied regex on DELETE /admin/cache #1609)
(a+)+$).dryRunmode.Validate params and body on admin id-based routes ([backend] Validate params and body on admin id-based routes #1610)
validate({ params })) with length and charset constraints across admin routes (:id,:key,:wallet,:artifactId).DELETE /admin/idempotency/keys/:keyreturning 400 instead of 500 whendecodeURIComponentfails.Mask secrets in diagnostics bundle and redact wallet addresses in logs ([backend] Stop partial secret disclosure in diagnostics bundle and raw wallet addresses in logs #1612)
JWT_SECRET) are never disclosed.walletQueryGuard,tenantBoundary, and structured logger.src/auth.ts:657and unified wallet address truncation/hashing.Related Issues
Closes #1608
Closes #1609
Closes #1610
Closes #1612
Testing
npm test -- --coverage=false adminCacheAndParams.test.ts diagnosticsBundle.test.ts webhookVerifyEndpoint.test.tspasses (14 tests passed).