Skip to content

ci: modernize node lts, reconcile staging and release workflows, and wire governance scripts - #1685

Merged
Junirezz merged 1 commit into
Junirezz:mainfrom
software321dev:feat/batch-1594-1595-1596-1597
Oct 19, 2026
Merged

Junirezz merged 1 commit into
Junirezz:mainfrom
software321dev:feat/batch-1594-1595-1596-1597

Conversation

@software321dev

Copy link
Copy Markdown
Contributor

Description

This PR resolves issues #1594, #1595, #1596, and #1597:

  1. Modernize Node LTS and Declare Engines ([general] Move CI off Node 20 (end of life) and declare engines #1597)

    • Created .nvmrc with active LTS Node 22.
    • Updated engines to "node": ">=22" across package.json, backend/package.json, frontend/package.json, and packages/api-schemas/package.json.
    • Updated all actions/setup-node workflow steps to consume node-version-file: '.nvmrc'.
  2. Fix Staging Deployment Reporting ([general] Stop staging deploy from reporting simulated deploys as success #1595)

    • Pinned soroban-cli to --version 21.0.0 in .github/workflows/staging-deploy.yml.
    • Replaced simulated echo statements with guarded real deploy steps and ensured PR comments are only posted when a real staging deploy completes.
  3. Reconcile Release Workflow & Branch Protection ([general] Reconcile release workflow with branch protection and changelog process #1596)

    • Aligned tag pattern in .github/workflows/release.yml with cliff.toml (v[0-9]+.[0-9]+.[0-9]+*).
    • Replaced direct git push origin HEAD:refs/heads/main to protected main branch with automated pull request creation using peter-evans/create-pull-request@v6.
  4. Wire Governance and Shell Scripts ([general] Wire up or delete root and shell scripts that nothing runs #1594)

    • Wired up uncalled validate:* scripts (validate:testing-strategy, validate:sprint-and-triage, validate:release-notes, validate:nfr-baselines, validate:incident-severity) into .github/workflows/codeowners-check.yml.
    • Fixed executable permissions (mode 100755) for all runnable shell scripts in scripts/ and root.

Related Issues

Closes #1594
Closes #1595
Closes #1596
Closes #1597

Testing

  • Verified pnpm and node versions against engine constraints.
  • Verified git file modes via git ls-files -s scripts/.
  • Checked YAML workflow syntax and config files.

…wire governance scripts

- Issue Junirezz#1597: Move all workflows off EOL Node 20 to supported Node LTS via .nvmrc and declare engines across all packages
- Issue Junirezz#1595: Pin soroban-cli to version 21.0.0 and guard staging deploy steps against simulated reporting
- Issue Junirezz#1596: Reconcile release tag pattern with cliff.toml and create PR for CHANGELOG.md against protected main
- Issue Junirezz#1594: Wire up validate:* checks in governance CI workflow and mark shell scripts executable (100755)

Closes Junirezz#1594, Closes Junirezz#1595, Closes Junirezz#1596, Closes Junirezz#1597
@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@software321dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Junirezz
Junirezz merged commit f4c60b7 into Junirezz:main Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants