Repository navigation
# fix(vault): bind admin in storage migration and align ForceUpgrade checkpoints (#1633) - #1690
Open
Awosdot wants to merge 1 commit into
Conversation
|
@Awosdot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
adminscope inrun_storage_migration(contracts/vault/src/lib.rs), ensuringadminis properly assigned beforeadmin.clone()event emission[cite: 13].ForceUpgradelogic withupgrade(), ensuring forced upgrades execute storage version checkpoints and migration routines[cite: 13].upgrade()andForceUpgradecontaining the old and new WASM hash alongside storage version data[cite: 13].Why
run_storage_migrationreferenced an out-of-scopeadminvariable, causing target build failures during WASM compilation[cite: 13]. Additionally,ForceUpgradebypassed version checkpoints and storage migrations entirely while emitting zero upgrade audit events[cite: 13].How tested
cargo build --target wasm32-unknown-unknown[cite: 13].cargo test -p vaultto confirm all upgrade and storage migration test suites pass cleanly[cite: 13].Closes
Closes #1633