Repository navigation
Fix/issues 1682 1683 1673 1668 - #1706
Merged
Junirezz merged 10 commits intoOct 20, 2026
Merged
Conversation
- Implements cspell with project dictionary for common terms - Adds lychee link checker to validate internal and external links - Includes npm license allowlist validation for dependencies - Generates SBOM artifacts for release transparency Resolves Junirezz#1664, Junirezz#1665, Junirezz#1666, Junirezz#1667
Map to TRIAGE_LABELS.md taxonomy with contracts, backend, frontend, docs, infra packages and critical, high, medium, low severity levels
Ensure every top-level directory has owner coverage
Runs contribution standards, testing strategy, sprint and triage, release notes, NFR baselines, CODEOWNERS, PR template, and Renovate validators with fail-fast on error
List each validate, test, build, and dev script with descriptions and usage guidance
…d setters Limit withdrawal cooldown to 1 year maximum to prevent indefinite locking. Bound large-withdrawal threshold to 95% of total assets to ensure sanity. Resolves Junirezz#1682
Clarify that shares are not reserved at request time and are priced at execution time based on current vault state. This means share price during timelock depends on vault activity after the request. Resolves Junirezz#1683
Ensure npm dependencies in packages/api-schemas are monitored for security updates and version bumps. Resolves Junirezz#1673
Add trivial severity label and stellar-wave special label to match repository label scheme. Ensures triage consistency across docs and practice. Resolves Junirezz#1668
|
@devmocrea Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four open issues related to contract safety, dependency management, and documentation consistency.
Changes Made
1. Add upper bounds to withdrawal cooldown and large-withdrawal threshold setters (#1682)
Added MAX_COOLDOWN constant (1 year) and validation to prevent indefinite deposit locking. Added upper bound check for large withdrawal threshold at 95% of total vault assets.
2. Document pending withdrawal share pricing behavior (#1683)
Added comprehensive documentation explaining that pending withdrawal shares are NOT reserved at request time and are priced at execution time based on current vault state.
3. Add missing package manifests to dependabot coverage (#1673)
Added npm ecosystem entry for
/packages/api-schemasdirectory to ensure security monitoring of its dependencies.4. Reconcile TRIAGE_LABELS.md with repository labels (#1668)
Updated documentation to include
trivialseverity label andstellar-wavespecial label, matching actual repository label scheme.Files Changed
contracts/vault/src/lib.rs.github/dependabot.ymlTRIAGE_LABELS.mdRelated Issues
Closes #1682
Closes #1683
Closes #1673
Closes #1668