Skip to content

Update jobState.hasKey documentation to cover edge case #696

Description

@austinkelleher

The Qualys integration was using awaiting the result of jobState.hasKey and firing off multiple promises with pQueue. The Qualys integration was occasionally seeing DUPLICATE_KEY_DETECTED errors being thrown despite checking whether the graph object _key exists before adding the new entity to the jobState. Tests were added as part of the investigation into the issue. See: #694

The Qualys integration fix can be found here: https://github.com/JupiterOne/graph-qualys/pull/190

The documentation and JSDoc code comments for jobState.hasKey should be updated to call out the caveats.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions