Code improvement, correction of potential vulnerabilities#254
Open
TheLivan wants to merge 15 commits into
Open
Code improvement, correction of potential vulnerabilities#254TheLivan wants to merge 15 commits into
TheLivan wants to merge 15 commits into
Conversation
it is completely equivalent to "sendOpenGui"
Other mods may have the same class names.
The String object is located in the string pool and may cause poor synchronization.
TheLivan
marked this pull request as draft
February 11, 2026 04:54
TheLivan
marked this pull request as ready for review
February 11, 2026 04:54
Contributor
Author
|
Hi @c0508383, what do you think of my PR? I'm ready to comment on any specific points. I'd really like to see it get merged |
somehussar
reviewed
Jul 8, 2026
Collaborator
There was a problem hiding this comment.
I don't kinda understand why null checks were removed here.
Collaborator
|
For me, the changes look good, just one questionable removed null-check in ClientTickHandler if you could explain it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey KAM! I tried to analyze the project with a static analyzer and correct what I thought were important points. Thank you for developing the Custom NPC mod.