🔄 Sync with upstream changes - #17
Open
h0lybyte wants to merge 638 commits into
Open
Conversation
* chore: action hardening Removes interpolation and uses env instead. General hardening and best practice. Not reachable by untrusted code (forks/PRs) * chore: more hard
We had the replay test failing more often than expected due to racing conditions between our tests and the inserts in the database which lead to a higher failure rate. This also reduces the log noise to be more single line focused instead of tables and more noise that it's not useful for the e2e usecase
…base#1864) This new endpoint sends a single broadcast with a JSON or binary payload The content-type declares what kind of payload is being sent
* chore: reduce e2e flakiness * chore: update nix node_modules hash --------- Co-authored-by: supabase-autofix-bot <noreply@supabase.com>
group g routes to: R ───────► T
view {R,S} view {R,S,T} (old router) (new router,
the node that just joined)
the node that just joined)
It fix a race where node S learns about the new node T before node R does:
┌──────┬─────────────────────────────────┬────────────────────────────────────┬──────────────────────────────────────┐
│ time │ node S (has a member of g) │ node R (thinks it's g's router) │ a broadcast to g right now… │
├──────┼─────────────────────────────────┼────────────────────────────────────┼──────────────────────────────────────┤
│ t0 │ cluster is {R,S}, agrees with R │ :ready, is g's router, table empty │ (nobody holds g yet) │
├──────┼─────────────────────────────────┼────────────────────────────────────┼──────────────────────────────────────┤
│ t1 │ discovers T → view {R,S,T} │ still on {R,S} (lagging) │ — │
├──────┼─────────────────────────────────┼────────────────────────────────────┼──────────────────────────────────────┤
│ t2 │ joins g → routes to T │ still thinks it's g's router │ — │
├──────┼─────────────────────────────────┼────────────────────────────────────┼──────────────────────────────────────┤
│ t3 │ — │ still :ready, table still empty │ routed to R → delivered to nobody ❌ │
└──────┴─────────────────────────────────┴────────────────────────────────────┴──────────────────────────────────────┘
The fix (two-phase view adoption): a node may not start routing joins under
a grown view until it has told its old view's members it is leaving — and they
have acked.
Collect how often we have "hits" when broadcasting. Notice that we are not tracking if the topic is populated just if there are potential targets/websockets.
* fix: migration realtime.uuid not null Ref REAL-924 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Ref REAL-925
* chore: update @supabase/supabase-js to v2.110.9 * chore: update nix node_modules hash --------- Co-authored-by: supabase-workflow-trigger[bot] <266661614+supabase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: supabase-autofix-bot <noreply@supabase.com>
* chore: update pgdelta supabase/pg-toolbelt@@supabase/pg-delta@1.0.0-alpha.30...@supabase/pg-delta@1.0.0-alpha.33 * chore: update tenant db catalog and dumps --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Also remove prod_linter as it's not being used
* chore: update @supabase/supabase-js to v2.111.0 * chore: update nix node_modules hash --------- Co-authored-by: supabase-workflow-trigger[bot] <266661614+supabase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: supabase-autofix-bot <noreply@supabase.com>
On a hot-path it's important to not re-query the DB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Sync
This PR contains the latest changes from the upstream repository.
Changes included:
Review checklist:
This PR was automatically created by the upstream sync workflow