Repository navigation
Raise Go coverage above 85 percent - #200
Merged
Merged
Conversation
novatechflow
force-pushed
the
test/coverage-above-85
branch
from
October 16, 2026 17:18
6173d89 to
67c9173
Compare
novatechflow
marked this pull request as ready for review
October 16, 2026 17:20
PaxMachinaOne
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the existing Go coverage total from 79.2% to 85.8% (4,844 of 5,647 statements), without changing the package scope or exclusions. Broker coverage rises from 52.1% to 94.5%.
Adds consumer-group tests for two-member join/sync and partition assignment, rebalance coordination, heartbeat validation, offset persistence and coordinator restart, member departure, group discovery/filtering, metadata fallback, session expiration, and store failures. Raises both the coverage script default and the CI floor from 45% to 85%, preserving the CI coverage summary and artifact upload.
Validation:
bash hack/check_coverage.shpasses at 85.8%; broker tests pass with the race detector; workflow passes actionlint; shell syntax and diff checks pass. Fullmake commit-checkpassed, including Go vet/race, nested modules, SDK tests, fuzzing, and the CodeQL gate.Docker-backed e2e tests cannot run locally because Docker is unavailable.
Rebased onto the coverage-reporting change in #199. Coverage remains 85.8% after the rebase. The original CI coverage gate and Go tests passed; GitHub has not attached new runs to the rebased commit yet.