Repository navigation
2段フリックの出力文字が消える問題を修正 / Fix lost two-step flick outputs - #1368
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
日本語
2段フリックの編集機能を再有効化した後も、キーの確定処理では
TWO_STEP_FLICKが既定の分岐に進んでいました。この分岐が通常入力と長押し用の割り当てを削除するため、「完了」の後にキー編集を開き直すと出力文字が空欄になっていました。TWO_STEP_FLICKを既存の保存処理に戻し、通常入力と長押し用の割り当てを編集中のレイアウトに保持して、再編集時に読み込めるようにしました。検証
既存のビルド成果物を依存に使い、変更対象のKotlinソースをコンパイルしてJUnitを実行しました。追加した回帰テストで修正前の出力消失を再現し、修正後は
KeyboardEditorViewModelFlexiblePlacementTestの86件すべてが通りました。English
After two-step flick editing was re-enabled, the key update still routed
TWO_STEP_FLICKthrough the default branch. That branch cleared both normal and long-press mappings when users tapped Done, so the outputs were blank when they reopened the key editor.TWO_STEP_FLICKnow uses the existing mapping save path. Both sets of outputs stay in the layout draft and can be loaded when the key editor opens again.Verification
Compiled the affected Kotlin sources against existing build artifacts and ran JUnit. The new regression test reproduced the lost outputs before the fix. All 86 tests in
KeyboardEditorViewModelFlexiblePlacementTestpassed after the fix.